CorruptedArk / open-chaos-chess

Open Chaos Chess is a free and open source version of Chaos Chess, stripped of Google Play Services.
GNU General Public License v3.0
50 stars 7 forks source link

Buggy moves and game doesn't stop #17

Closed berkaygunduzz closed 3 years ago

berkaygunduzz commented 3 years ago

Describe the bug Buggy moves (it can happen anytime but playing fast increases possibility) and game doesn't stop when i even won

To Reproduce Steps to reproduce the behavior:

  1. Play a game (especially fast)

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If it's not enough i can share full mp4 video High Res bug Low Res bug_low

Smartphone (please complete the following information):

CorruptedArk commented 3 years ago

This is a real tricky one to understand. No matter how quickly I press the pieces when I play, I can't reproduce the issue.

berkaygunduzz commented 3 years ago

A long time ago i tried to make a game, i had a similar bug, i've fixed it with seperating render (display activities) and update (main activities) and make update fixed to 60 for second. Sorry for i I didn't study to your code but can it about that?

CorruptedArk commented 3 years ago

I'm not sure. The game is pretty heavily multi-threaded to prevent the UI from completely freezing during a move, so the exact logic is complicated.

CorruptedArk commented 3 years ago

I'm not sure if this is a problem with the game or a problem with your phone. Does this problem occur when your battery is fully charged? Is your phone rooted or running any extra software in the background?

CorruptedArk commented 3 years ago

I'm testing on Android 9 as well, so it's not an API issue

berkaygunduzz commented 3 years ago

K, i will try it with full charge, it can take some hours. Btw I see in strings.xml file there is wait your turn warning, why i can't see it on my game? Is it just for multi?

berkaygunduzz commented 3 years ago

It's not rooted and there was nothing running background except message programs.

CorruptedArk commented 3 years ago

Weird, and at the moment that warning doesn't appear for me either. I think it stopped showing up a while back when I changed the way it blocks a move during animations. I think it still shows up in multiplayer, though.

CorruptedArk commented 3 years ago

Would you be willing to to try building from source or at least test the signed Github release? Maybe the problem has something to do with F-Droid's build

berkaygunduzz commented 3 years ago

This?

CorruptedArk commented 3 years ago

Yeah, that is built and signed directly by me

berkaygunduzz commented 3 years ago

I can also try building from source if there is a guide for that

CorruptedArk commented 3 years ago

I don't have a guide put together, so you don't have to do that if you don't already know how. The built release should be the same anyway

berkaygunduzz commented 3 years ago

bug GitHub release Looks like it's about making moves before computer.

berkaygunduzz commented 3 years ago

Still i can try when fully charged, but i can't try while charging. Also points are interesting and game doesn't count king and doesn't finish.

berkaygunduzz commented 3 years ago

Is it supposed to queue move? Taking no moves isn't much better than it?

berkaygunduzz commented 3 years ago

Ok, i tried with 30% and 100% charge and there was no buggy moves, probably at low battery processor slows down so it lags, but still i can't see wait your turn.

CorruptedArk commented 3 years ago

It is not currently intended to queue moves, so it's alright that it doesn't show "Wait your turn"

CorruptedArk commented 3 years ago

Since this issue isn't a problem caused by the game itself and the warning not showing up is currently intended behavior, I'm closing this issue for now. I still may look into the warning, though.

berkaygunduzz commented 3 years ago

Thanks for your help anyway

CorruptedArk commented 3 years ago

Of course, I'm glad to help as much as I can. Thank you for providing helpful feedback