search

CorruptedArk / open-chaos-chess

Open Chaos Chess is a free and open source version of Chaos Chess, stripped of Google Play Services.
GNU General Public License v3.0
50 stars 7 forks source link

Selections colour change not honoured #19

Closed d5xtgr closed 3 years ago

d5xtgr commented 3 years ago

The settings allow you to change many of the colours used in the app, but the selections colour is ignored and reset upon leaving the activity. Inspecting settings.txt, the entry remains FF888888 in uppercase, while all other entries reflect the user's entry and are in lowercase.

It looks to me like there ought to be a corresponding entry like colorManager.updateColor(ColorManager.SELECTION_COLOR, getColorInt(selectionColorButton)); around line 236 of SettingsActivity.java. I have not tested to see if that fixes it, but it seems suspicious to have the selection colour absent from among all the others here.

CorruptedArk commented 3 years ago

Good catch, I'll look into it

CorruptedArk commented 3 years ago

I just pushed a commit that appears to fix this issue. Your suggestion was a correct part of the fix, but not all of it. Good offhand guess