search

CorruptedArk / open-chaos-chess

Open Chaos Chess is a free and open source version of Chaos Chess, stripped of Google Play Services.
GNU General Public License v3.0
50 stars 7 forks source link

Merge versus activities in the single one #42

Closed egorguslyan closed 3 years ago

egorguslyan commented 3 years ago

Host and client work fine. Main menu: Screenshot_20210502-094003_Open_Chaos_Chess Start multiplayer game: Screenshot_20210502-094021_Open_Chaos_Chess_1 Client: Screenshot_20210502-094035_Open_Chaos_Chess Host: Screenshot_20210502-094052_Open_Chaos_Chess Linking issue #41

CorruptedArk commented 3 years ago

I've done some preliminary testing and I have concerns with this implementation. Consolidating the two activities may make the main menu cleaner, but it makes it more difficult to determine which device will be the host and which will be the client. It also appears to cause crashes on devices without Bluetooth rather than explicitly display an error. As the changes are right now, I cannot accept them.