search

CorsairOfficial / cue-sdk

Corsair iCUE SDK
https://corsairofficial.github.io/cue-sdk/
220 stars 24 forks source link

Examples folder missing from SDK package 4.0.48 #34

Open eSonOfAnder opened 1 year ago

eSonOfAnder commented 1 year ago

As of 6-Sep 2023, the current version of the iCUE SDK package is 4.0.48. The included PDF documentation says that there should be an examples folder in this archive with a sample project, but this folder does not exist. If this was removed intentionally, the document should be updated to reflect that (and it should also be included in the release notes). The better solution would be to add the sample project back to the distributed SDK package, as documented.

hasteagag commented 1 year ago

3.0.464 appears to be the version publicly available on the corsair site. Also a note, the PDF in the docs in the latest release on github has the previous protocol version (15) so I would guess that is out of date should anything have changed. I am tempted to check if swapping the lib etc has any effect on the examples, but I havent yet

hasteagag commented 1 year ago

Well I had a look at the last commit, and it looks like a lot changed. Groups seem like a great addition, to categorize entire sections of a lighting setup (CorsairLedGroup) and the overall enum looks like it was dramatically simplified rather than a bunch of slocs of incremented Leds. I havent spotted it but it must be done as needed or more efficiently. So I think that would break many of the lighting examples out of the box, so thats probably why it was dropped. I suspect it will return soon.

eSonOfAnder commented 1 year ago

Interesting, because I was not sure where to grab the SDK from, and if you do a Google search for it, you will end up here and not on the Corsair site. So if the "latest release" here is not actually the "latest release", then it should be labeled as such, or mentioned in the readme.md. The original bug, as reported, is still valid as is, because 4.0.48 is listed as the latest release, and it clearly is missing both what I reported, along with all of the undocumented changes mentioned above.

hasteagag commented 1 year ago

hotlink to corsair site for prior release for convenience: https://downloads.corsair.com/Files/CUE/CUESDK_3.0.464.zip