Corsinvest / cv4pve-barc

Backup And Restore Ceph for Proxmox VE
https://www.cv4pve-tools.com
GNU General Public License v3.0
82 stars 22 forks source link

fsfreeze support + improved reporting + renew policy + checksumming + compression #41

Closed lephisto closed 4 years ago

lephisto commented 4 years ago

This includes the changes from the previous PR as well as the option, to renew the full backup every X Snapshots to increase safety on Backups. In the original version you would rely on never getting problems with your storage and a resilvering filesystem underneath.

Review would be nice.

franklupo commented 4 years ago

Good. What do you think of moving fsfreeze from the hook script into the main script? If necessary we create a parameter --qemu-freeze

Best regards

lephisto commented 4 years ago

Yes sure, this could be done. Still, i'm working on making the restore function with the whiptail options compatible with the renew options..

lephisto commented 4 years ago

I added some more stuff. maybe you wanna look at it..

franklupo commented 4 years ago

In the next days i test fix Best regards

franklupo commented 4 years ago

Don't use eval but do_run(). This fiction support parametr dry-run for testing.--try-run and --debug is not documentate but show comand and no esecute

franklupo commented 4 years ago

Freeze work only qemu no Lxc. Filter execution only qemu.

lephisto commented 4 years ago

OK, will change this evening..

franklupo commented 4 years ago

How work import if compress backup?

lephisto commented 4 years ago

Restore w/ compression is still WIP.

lephisto commented 4 years ago

There's a ton of changes now.. restore with decompress / checksum validation is in now, i did some tests. Other testers welcome :)

lephisto commented 4 years ago

Ideas:

franklupo commented 4 years ago

Great ideas. But first I think it's worth testing this code and then releasing. It would be interesting to design tests to always check that everything is ok, If you agree, you could create a new TODO issue where all the ideas could be inserted.

lephisto commented 4 years ago

Yes, feedback is much appreciated..