search

Corsinvest / cv4pve-barc

Backup And Restore Ceph for Proxmox VE
https://www.cv4pve-tools.com
GNU General Public License v3.0
82 stars 22 forks source link

[Discussion] Remove Snapshot merging / legacy Code? #43

Open lephisto opened 4 years ago

lephisto commented 4 years ago

Since there are currently two approaches in the Codebase, I want to discuss if you want to keep the ability to merge snapshots into each other. I personally wouldn't dare to go on and take one Base Snapshot in a year, and then only merge onto it. And: There's no way to merge into the Basecopy, so the volatile data would accumulate in the first Differential file after the Basecopy.

franklupo commented 4 years ago

what do you propose?

franklupo commented 4 years ago

Add option --disable-merge-snapshot to disable merge.

lephisto commented 4 years ago

There's no need to do, because it won't merge snapshots in --renew mode. in --keep mode it does behave like it always did.

franklupo commented 4 years ago

What idea do you have for this?

lephisto commented 4 years ago

The idea was to compeltely remove all merge logic since it you might not detect if something goes wrong until you try to restore stuff. For now let's keep it in, and keep backwards compatibility..

franklupo commented 4 years ago

Ok for me good idea remove all merge logic