Corsinvest / cv4pve-barc

Backup And Restore Ceph for Proxmox VE
https://www.cv4pve-tools.com
GNU General Public License v3.0
82 stars 22 forks source link

[Bug-0.2.5-renew] Status display bug due to date format change of the year #56

Open MRLOLKOPF opened 4 years ago

MRLOLKOPF commented 4 years ago

Hi,

I just tested the new version (0.2.5-renew) on my test Proxmox environment, unfortunately I found some bugs. I might try to fix them myself and make a pull request, but due to the corona situation I'm quite busy now. Just want to report those bugs, so that others might be aware of it. But really nice improvements with fsfreeze, checksum check, etc.!!

This bug is just a cosmetic issue, this does not have any functional impact! At least I didn't recognized any.

As far as I saw, the date format for the year was changed from "20" to "2020" in the new version. As you can see the year is splitted "20-20" and the seconds moved into the name of the image.

root@pve03:~# eve4pve-barc status --vmid=102 --label='daily' --path=/mnt/pve/bak2hetznerCeph
VM  TYPE SIZE  BACKUP            IMAGE
102 img    15G 20-20-04 05:11:22 37RBD01.vm-102-disk-0 
102 sha1    44 20-20-04 05:11:22 37RBD01.vm-102-disk-0.img 
102 size    12 20-20-04 05:11:22 37RBD01.vm-102-disk-0.img.sha1 

Stay healthy! Greetings from Germany! Andy

franklupo commented 4 years ago

@lephisto do you have any idea?

lephisto commented 4 years ago

@MRLOLKOPF Hi Andy,

yes I changed the Dateformat, and there might be some formatting issues. I will dig into it. By the way, it's more a cosmetic issue.

This is how it should look like with the most recent version.

VM   TYPE COMP        SIZE UNCOMP       BACKUP           IMAGE
1337 diff zz    20.35 MiB 180.28 MiB    20200410170002 ssd-pool:vm-1337-disk-0
                                  sha1: 4a534298c3a2e7dbd41371df834bb1c5e37c9815
1337 diff zz   777.10 MiB 776.86 MiB    20200410170002 hdd-pool:vm-1337-disk-3
                                  sha1: e213aea9d7def20e595365918a4786f1bd633386
1337 diff zz     74 Bytes 78 Bytes      20200410170002 hdd-pool:vm-1337-disk-0
                                  sha1: 71e52f3da00365f32d09e3139bfbd022186b1aaa
1337 img  zz     9.17 GiB 40.00 GiB     20200410070001 ssd-pool:vm-1337-disk-0
                                  sha1: 217336e0bc51f77a6ff8d0c905ba73db19b7ec43
1337 img  zz   221.86 GiB 250.00 GiB    20200410070001 hdd-pool:vm-1337-disk-3
                                  sha1: 2fdc36c6b38a55dc3649dcf6569ef43baa666e22
1337 img  zz     6.31 GiB 25.00 GiB     20200410070001 hdd-pool:vm-1337-disk-0
                                  sha1: f144d0850683e0d5e003d94a540c1f2b85abd078
franklupo commented 4 years ago

HI, I fixed it using a single regex for everyone. and to be verified by downloading the code

Best greards