add an option to specify the proxy in fetched .vv file

Corsinvest / cv4pve-pepper

Launching SPICE remote-viewer for Proxmox VE VDI client

https://www.corsinvest.it/cv4pve

GNU General Public License v3.0

98 stars 15 forks source link

add an option to specify the proxy in fetched .vv file #11

Closed gitercn closed 3 years ago

gitercn commented 3 years ago

As discussed in this issue https://github.com/Corsinvest/cv4pve-pepper/issues/10, I'm using Proxmox VE through a reverse proxy, and I want to specify the port in the fetched *.vv file. So I add an option to modify it. Could you merge it to the master branch? If you have any opinions feel free to modify it.

franklupo commented 3 years ago

Nice idea yours. I would reuse the --proxy parameter. If the value starts 'http: //' I execute complete replace of the proxy parameter in the .vv file. It seems to me a cleaner solution without creating new parameters

Best regards

franklupo commented 3 years ago

Fix in release 1.3.9