[Bug] Small bug: cash register sound played in triplicate when rising salary

[masterofobzene]

Describe the issue

The cash register sound is played 3 times instead of one, when giving a rise to complaining personel. While this is a very small bug, it gives wrong feedback to the player thinking he gave more than what was expected.

Steps to Reproduce

1. Give the rise that the complaining doctor asks for and listen.

Expected Behaviour

To listen only one "tchint!" sound instead of many.

Have you enabled any current CorsixTH Experimental Features?

• [ ] Right mouse panning
• [ ] Falling actions

Save Game

Save game attached to report: No

CorsixTH Version

0.68

Operating System

Windows 10 x64

Theme Hospital Version

GOG.com

Gamelog.txt

no game log on 0.68 for me

Additional Information

no game log on 0.68 for me

[MandrakeHorse]

In Theme Hospital:

• [ ] The single cash register sound ("BONUS2") plays when the user accepts a staff member's demand for a pay rise or when they grant a bonus via the Staff Management screen
• [ ] The triple cash register sound ("BONUSAL2") plays when the user manually grants a pay rise via the Staff Management screen

It seems that CorsixTH uses the triple cash register sound when accepting a staff member's demands for consistency - whether through the Staff Resignation pop-up or Staff Management screen, their salary has increased, so the same sound is used.

[lewri]

I think I understand the report. This behaviour was changed in #2219 while fixing other sound bugs with wage requests. It felt a bit misleading to play the single cash register sound for both giving a bonus and also increasing wage hence the change.

It could be changed back, but would you say that the sound change is detrimental at all?

[MandrakeHorse]

On the subject of inconsistencies with Theme Hospital's pay rises:

• [ ] the Staff Resignation panel represents a pay rise with three moneybags
• [ ] the Staff Management screen uses a single moneybag to represent a one-off bonus and a cheque to represent a payrise.

Perhaps once we're able to modify and provide our own UI, we should replace the three moneybags with the cheque.

[lewri]

Wage requests usually can demand more money than one from the staff management window, since they definitely conduct the fair wage check like we do. The 3 moneybags imply some sense here but I agree it's just a little inconsistent on the UI.

[MandrakeHorse]

You could also argue that it makes more sense to play the triple cash register sound (BONUSAL2) when granting a raise via the Staff Resignation panel because the "Meet the pay demand" button has three moneybags!

Personally, I wouldn't consider this to be a bug and that Theme Hospital technically uses the "wrong" sound effect on the Staff Resignation panel (see below). If we decided to revert back to the single cash register sound (BONUS2), then we would probably need to change the Staff Management's "Raise this person's salary by 10%" button as well for the sake of consistency - at which point, we'd have two different buttons with the same sound, which isn't good sound design.

(Tangent: According to the dev comments that accompany each sound effect, BONUS2 has the description of "Pay bonus to a person v.2" while BONUSAL2 reads "Pay bonus to all (up wage actually) v.2". This suggests that during development, there were plans to allow the player to grant bonuses to multiple staff members simultaneously via Staff Management. After the idea was scrapped, the triple cash register sound effect was repurposed for increasing staff wages. If these comments are strictly adhered to, then it implies that the Staff Resignation panel incorrectly uses the "Pay bonus" sound instead of the "Up wage" sound.)