search

CorsixTH / CorsixTH

Open source clone of Theme Hospital
Other
4.04k stars 368 forks source link

Psychiatrist is stuck in the psychiatry room #332

Closed mpmc closed 9 years ago

mpmc commented 10 years ago

OS/Build: Win 7 x64 SDL, 0.40b1:

Problem: Psychiatrist wonders around the room while heading to GP's office, also walks under the couch loosing his head.. ;) image

MarkL1961 commented 10 years ago

I think both these are known issues here and here

TheCycoONE commented 10 years ago

Looks the same indeed, so not a regression, but not yet in GitHub. We'll leave this open.

I'm not sure to what extent this is game breaking. I'm leaning towards not blocking 0.40 with this since it's been a problem forever, but if someone wrote a fix it would probably be accepted.

TheCycoONE commented 10 years ago

I'd like this issue to be primarily about the physician stuck in psychiatry (or other room) issue.

MarkL1961 commented 10 years ago

Pick up and put back seems to work. As for the glitch with animation, there are many of those. Neither stop the game or cause a crash

J-Shep commented 10 years ago

I will spend some time investigating this bug today if no one is already trying to find a fix for it.

J-Shep commented 10 years ago

I can't investigate this bug now because my Windows PC will be unusable until Friday and the Ubuntu 14.04 PC I can sometimes use is currently not set up to compile CorsixTH.

TheCycoONE commented 10 years ago

Ok, thanks for the update @J-Shep

MarkL1961 commented 10 years ago

@J-Shep For pure lua changes you don't need to compile, only when there are c+ code changes

J-Shep commented 10 years ago

@mpmc If you have a saved game with this stuck psychiatrist in it please upload it.

mpmc commented 10 years ago

@J-Shep Unfortunately I don't have the SAV anymore, I have tried to get it to happen again but no luck I'm afraid.

J-Shep commented 10 years ago

Unfortunately I don't have the SAV anymore, I have tried to get it to happen again but no luck I'm afraid.

No problem, thanks for trying to reproduce this error. There's an ancient beta 8 saved game which has the same problem so if I can fix this error in beta 8 then maybe I won't have to change my fix too much for it to be compatible with 0.40 .

I will try to fix this error asap.

phillipp commented 10 years ago

Pull request will fix the behaviour. Tested and fix verified with the save from the google code issue.

MarkL1961 commented 10 years ago

Doctors can sometimes get stuck in the GP office, will this fix that as well?

phillipp commented 10 years ago

Hm, interesting. I did not see that before. I will look into it.

phillipp commented 10 years ago

@MarkL1961 Do you have any specific instructions, how I could reprduce the problem where doctors get stuck in GP's office?

MarkL1961 commented 10 years ago

No, it is just something you start to notice as queues build up and you see there is a Dr in the GP room walking around the room whilst the patient sits there. I have noticed that they are ready for a break, but that could well be a symptom of walking around not the cause.

phillipp commented 10 years ago

So it is more like 'the doctor should rest, but isn't resting' instead of 'wouldn't take calls from call dispatcher'?

MarkL1961 commented 10 years ago

I think it is that they don't know the patient is in the room and are waiting for one to enter. Normally if there is a patient they either sit at the desk or use the filing cabinet. Instead they wander the room. One time I placed another Dr in the room expecting the first one to leave, but they both just wandered the room as if they were waiting for a patient. There is perhaps some problem with the door code, waiting for the patient who is already in the room so they can leave/deal with the patient.

phillipp commented 10 years ago

Okay, I will test that.