CorsixTH crash with updated Sound-1.dat french file - Githubissues

CorsixTH / CorsixTH

Open source clone of Theme Hospital

Other

4.03k stars 366 forks source link

CorsixTH crash with updated Sound-1.dat french file #665

Open legluondunet opened 9 years ago

legluondunet commented 9 years ago

Hello,

in this unofficial patch: http://hospital.ragondin-earth.org/ you have a sound file: sound-1.dat wich corrects several french sound bugs: Google translation: "Using a utility that allows you to read / change the sounds of Theme Hospital, I found, to my surprise, that new sounds were present in the English version of the game that we could not find in other languages of the game. in addition, I found that some ads from the receptionist was slightly incorrect, especially about the message saying that a medical researcher had expected an electrolysis chamber while a regular doctor could suffice, or , the service call to the arrival of patients victims of "heart-breaking." I also found a strange bug in relation to incorrect locations in the sound file on some calls from the receptionist, especially about excuses or service call messages. Unfortunately, in this case, I found that only 5 service calls work, the others being silent for some reason."

But if I install this file Corsix crash at start.

$ ./CorsixTH -h

Welcome to CorsixTH Trunk!

This window will display useful information if an error occurs.

Erreur de segmentation (core dumped)

It will be greatly appreciate by french TH gamers if CorsixTH could could tolerate this file.

LGDN.

SimplyRyan commented 9 years ago

I can't speak for the file in question but if you could play CorsixTH without this modification and report any issues then we can make the required fixes (Its also worth noting that the original game had this bug and CorsixTH simply doesn't replicate the issue.). We already correct a few text issues with the orignal game by using overrides in the French lanauge file, you can see these here - https://github.com/CorsixTH/CorsixTH/blob/master/CorsixTH/Lua/languages/french.lua

legluondunet commented 9 years ago

This patch seems heavily used by TH french gamers. So I opened this issue for several reasons:

let a trace on the internet of incompatibility between this patch and Corsixth
inform Corsixth team A crash give only one information to the user: that software doesn't work. Perhaps you could add to corsixth a file verification that prevent users to use modified files? Or inform them, at the corsixth launch, that they are using a patch that is not supported by corsixth and could crash it.

MarkL1961 commented 9 years ago

If you are having problems with sound effects, there was an issue that became known after 0.40 was released as one or more sound effects relating to the gates of hell were causing a crash. If that is what you are having a problem with, then this was fixed by this update in the trunk.

legluondunet commented 9 years ago

MarkL1961, I'm using the last CorsixTH git, so your update does not work with this sound file. Perhaps you could test it?

MarkL1961 commented 9 years ago

You should remove that link please as it could be taken as distributing the original files. Lang is the written text, such as what the advisor tells you and menu names etc. It should not cause the game to crash, but there have been issues with the correctness of some translations. As Ryan as already said we can override those sorts of mistakes and already have done when they have been pointed out to us. If it sound effects or announcements etc then it is sound-1.dat as in the title of this issue that needs to be checked

MarkL1961 commented 9 years ago

I am not getting any crash from the language file. I can't comment on the actual text as I can't read or speak French.

legluondunet commented 9 years ago

you tested it with the last corsixTH version from git?

MarkL1961 commented 9 years ago

No, against 0.40. Do you want me to test against trunk as well? Only I cannot do that as the latest build is looking for lfs which I don't have! Perhaps @Lego3 or @TheCycoONE can do that?

MarkL1961 commented 9 years ago

Tested with latest build and all seems fine

legluondunet commented 9 years ago

ok thank you Mark :).

MarkL1961 commented 9 years ago

Does this mean your problem was not with the language or sound file, but the missing .dll's?

legluondunet commented 9 years ago

@MarkL1961 Mark I just compiled the last git version, applied the patch and CorsixTH crash at start, without another message than "segmentation fault, core dumped". But If I replace the "sound-1.dat" by the original one, CorsixTH no more crash. I closed this issue because I don't want to annoying dev with bugs from an unofficial patch.

MarkL1961 commented 9 years ago

What is this patch doing? If it is to correct text, we can do that, if it is to correct sounds then you are best sticking with the original for now. Only you have mentioned sound-1.dat and also LANG-1.DAT, which is the language file (which is what you linked to).

legluondunet commented 9 years ago

Mark I gave you a link to the wrong file, it's sound-1.dat from the patch wich make CTH crash, not LANG-1.DAT. In the TH french version, some speechs from the receptionist are not correct or missed, this modified sound-1.dat file corrects that.

MarkL1961 commented 9 years ago

I think for now you will have to put up with the missing sounds. Perhaps one day we will have our own, but for now I am not aware of anyone working on this.

lewri commented 4 weeks ago

Do we still wish to pursue supporting this? I'm not sure what specific part of the patched dat file leads to crashing, but I would guess the Level 5 fix only version should work out the box?