search

CortexPE / Commando

A Command Framework virion for PocketMine-MP
GNU Lesser General Public License v3.0
70 stars 53 forks source link

Subcommands show as optional #20

Closed inxomnyaa closed 5 years ago

inxomnyaa commented 5 years ago

grafik I registered sub commands in a BaseCommand (mye), but the first argument (entity | item), which is the subcommand's name, appears to be optional When i try to autocomplete the second argument (after entity | item), it shows me all options of the entity and item subcommand Is there any way to work around this?

CortexPE commented 5 years ago

That's intentional because the parent command can still execute under certain conditions

On Thu, Sep 19, 2019, 11:44 AM XenialDan notifications@github.com wrote:

[image: grafik] https://user-images.githubusercontent.com/8733998/65211731-0715c300-daa0-11e9-863e-971fd9213bbb.png I registered sub commands in a BaseCommand (mye), but the first argument (entity | item), which is the subcommand's name, appears to be optional When i try to autocomplete the second argument (after entity | item), it shows me all options of the entity and item subcommand Is there any way to work around this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CortexPE/Commando/issues/20?email_source=notifications&email_token=AEHQQFETGWOBB3TVQJI6N7TQKLYP7A5CNFSM4IYGAUR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HMJS7AQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AEHQQFHDLYLBI7QBQHM2OGTQKLYP7ANCNFSM4IYGAURQ .

inxomnyaa commented 5 years ago

Is it still somehow possible to make minecraft complete it when pressing tab? right now i have to type "entity" and "item" manually

CortexPE commented 5 years ago

Actually, I think I did some local changes that uses enums to make it 100% vanilla-like

I'll go look for it and push it

On Thu, Sep 19, 2019, 5:34 PM XenialDan notifications@github.com wrote:

Is it still somehow possible to make minecraft complete it when pressing tab? right now i have to type "entity" and "item" manually

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/CortexPE/Commando/issues/20?email_source=notifications&email_token=AEHQQFD67X7NUKVZ7OSXXDLQKNBQ5A5CNFSM4IYGAUR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7C3IIQ#issuecomment-533050402, or mute the thread https://github.com/notifications/unsubscribe-auth/AEHQQFH7QHE6BOMWGOAQZ23QKNBQ5ANCNFSM4IYGAURQ .

lukeeey commented 5 years ago

@CortexPE we discussed this before remember there is a way to get them to show as subcommands. is that what you are talking about?

CortexPE commented 5 years ago

Yeah I did the changes on my local files... Not on remote yet

On Fri, Sep 20, 2019, 7:53 PM Luke notifications@github.com wrote:

@CortexPE https://github.com/CortexPE we discussed this before remember there is a way to get them to show as subcommands. is that what you are talking about?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CortexPE/Commando/issues/20?email_source=notifications&email_token=AEHQQFFEDZW4PUYOWHIGKYLQKS2S3A5CNFSM4IYGAUR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7GOM2I#issuecomment-533522025, or mute the thread https://github.com/notifications/unsubscribe-auth/AEHQQFCMRVSJJQ2SS2ARJZTQKS2S3ANCNFSM4IYGAURQ .

inxomnyaa commented 5 years ago

Many thanks ❤️