Closed aviallon closed 5 years ago
Well I don't know if Cortex is a good or a bad programmer :P, so if another entity got caught into that list, it wouldn't be affected. But actually, yeah, it's quite redundant.
Le jeu. 27 sept. 2018 à 13:18, NycuRO notifications@github.com a écrit :
@NycuRO commented on this pull request. Why you check if player instanceof Player? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CortexPE/TeaSpoon/pull/312#pullrequestreview-159396069, or mute the thread https://github.com/notifications/unsubscribe-auth/AHIgjJBbZea7vsg9sY5lYrLPVGgNxl69ks5ufLQSgaJpZM4W5czo .
@NycuRO commented on this pull request.
Why you check if player instanceof Player?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CortexPE/TeaSpoon/pull/312#pullrequestreview-159396069, or mute the thread https://github.com/notifications/unsubscribe-auth/AHIgjJBbZea7vsg9sY5lYrLPVGgNxl69ks5ufLQSgaJpZM4W5czo .
Server::get online players() returns an array of players... This is on the pocketmine-mp API, not my issue if it returns a nulled player :joy:
Well I don't know if Cortex is a good or a bad programmer :P, so if another entity got caught into that list, it wouldn't be affected. But actually, yeah, it's quite redundant.
Le jeu. 27 sept. 2018 à 13:18, NycuRO notifications@github.com a écrit :