search

CortexPE / TeaSpoon

☕ A PLUGIN to Extend PMMP's Functionality without completely changing it.
GNU Affero General Public License v3.0
143 stars 100 forks source link

Fishing Hook is scheduled to update when the entity is closed. #317

Closed teracube closed 5 years ago

teracube commented 5 years ago

@CortexPE @larryTheCoder

thanks

https://poggit.pmmp.io/r/43529/TeaSpoon_dev-248.phar https://jenkins.pmmp.io/job/PocketMine-MP/1573/

2018-10-17 [19:53:31] [Server thread/CRITICAL]: InvalidStateException: "Cannot schedule update on garbage entity CortexPE\entity\projectile\FishingHook" (EXCEPTION) in "src/pocketmine/entity/Entity" at line 1407
2018-10-17 [19:53:31] [Server thread/DEBUG]: #0 src/pocketmine/entity/Entity(2007): pocketmine\entity\Entity->scheduleUpdate()
2018-10-17 [19:53:31] [Server thread/DEBUG]: #1 TeaSpoon_dev-248.phar/src/CortexPE/Session(77): pocketmine\entity\Entity->flagForDespawn()
2018-10-17 [19:53:31] [Server thread/DEBUG]: #2 TeaSpoon_dev-248.phar/src/CortexPE/item/FishingRod(114): CortexPE\Session->unsetFishing()
2018-10-17 [19:53:31] [Server thread/DEBUG]: #3 src/pocketmine/Player(2457): CortexPE\item\FishingRod->onClickAir(pocketmine\Player object, pocketmine\math\Vector3 object)
2018-10-17 [19:53:31] [Server thread/DEBUG]: #4 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(136): pocketmine\Player->handleInventoryTransaction(CortexPE\network\InventoryTransactionPacket object)
2018-10-17 [19:53:31] [Server thread/DEBUG]: #5 TeaSpoon_dev-248.phar/src/CortexPE/network/InventoryTransactionPacket(81): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleInventoryTransaction(CortexPE\network\InventoryTransactionPacket object)
2018-10-17 [19:53:31] [Server thread/DEBUG]: #6 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(96): CortexPE\network\InventoryTransactionPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
2018-10-17 [19:53:31] [Server thread/DEBUG]: #7 src/pocketmine/network/mcpe/protocol/BatchPacket(114): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(CortexPE\network\InventoryTransactionPacket object)
2018-10-17 [19:53:31] [Server thread/DEBUG]: #8 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(96): pocketmine\network\mcpe\protocol\BatchPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
2018-10-17 [19:53:31] [Server thread/DEBUG]: #9 src/pocketmine/Player(3056): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
2018-10-17 [19:53:31] [Server thread/DEBUG]: #10 src/pocketmine/network/mcpe/RakLibInterface(161): pocketmine\Player->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
2018-10-17 [19:53:31] [Server thread/DEBUG]: #11 vendor/pocketmine/raklib/src/server/ServerHandler(98): pocketmine\network\mcpe\RakLibInterface->handleEncapsulated(string 212.XXX.XXX.248 55266, raklib\protocol\EncapsulatedPacket object, integer 0)
2018-10-17 [19:53:31] [Server thread/DEBUG]: #12 src/pocketmine/network/mcpe/RakLibInterface(102): raklib\server\ServerHandler->handlePacket()
2018-10-17 [19:53:31] [Server thread/DEBUG]: #13 src/pocketmine/network/Network(94): pocketmine\network\mcpe\RakLibInterface->process()
2018-10-17 [19:53:31] [Server thread/DEBUG]: #14 src/pocketmine/network/mcpe/RakLibInterface(92): pocketmine\network\Network->processInterface(pocketmine\network\mcpe\RakLibInterface object)
2018-10-17 [19:53:31] [Server thread/DEBUG]: #15 vendor/pocketmine/snooze/src/SleeperHandler(120): pocketmine\network\mcpe\RakLibInterface->pocketmine\network\mcpe\{closure}()
2018-10-17 [19:53:31] [Server thread/DEBUG]: #16 vendor/pocketmine/snooze/src/SleeperHandler(82): pocketmine\snooze\SleeperHandler->processNotifications()
2018-10-17 [19:53:31] [Server thread/DEBUG]: #17 src/pocketmine/Server(2259): pocketmine\snooze\SleeperHandler->sleepUntil(double 1539798811.5944)
2018-10-17 [19:53:31] [Server thread/DEBUG]: #18 src/pocketmine/Server(2134): pocketmine\Server->tickProcessor()
2018-10-17 [19:53:31] [Server thread/DEBUG]: #19 src/pocketmine/Server(1700): pocketmine\Server->start()
2018-10-17 [19:53:31] [Server thread/DEBUG]: #20 src/pocketmine/PocketMine(249): pocketmine\Server->__construct(BaseClassLoader object, pocketmine\utils\MainLogger object, string /home/myserver/, string /home/myserver/plugins/)
2018-10-17 [19:53:31] [Server thread/DEBUG]: #21 /home/myserver/PocketMine-MP.phar(1): require(string phar:///home/myserver/PocketMine-MP.phar/src/pocketmine/PocketMine.php)
2018-10-17 [19:53:31] [RakLibServer thread/NOTICE]: Blocked 212.XXX.XXX.248 for 5 seconds
larryTheCoder commented 5 years ago

Well you can close the issue if you find out that this been fixed, I not sure if it is.

teracube commented 5 years ago

@CortexPE @larryTheCoder

teste half day on my server build 5803ad1 https://poggit.pmmp.io/r/43623/TeaSpoon_dev-249.phar https://jenkins.pmmp.io/job/PocketMine-MP/1573/artifact/PocketMine-MP.phar

and no errors ; - )

thanks

larryTheCoder commented 5 years ago

Works