search

CortexPE / TeaSpoon

☕ A PLUGIN to Extend PMMP's Functionality without completely changing it.
GNU Affero General Public License v3.0
143 stars 100 forks source link

DoubleChestInventory 💀 #322

Closed teracube closed 5 years ago

teracube commented 5 years ago

@CortexPE @larryTheCoder

thanks

https://poggit.pmmp.io/r/44084/TeaSpoon_dev-252.phar https://jenkins.pmmp.io/job/PocketMine-MP/1604/

2018-10-27 [14:40:56] [Server thread/CRITICAL]: Error: "Call to a member function getContents() on null" (EXCEPTION) in "src/pocketmine/inventory/DoubleChestInventory" at line 76
2018-10-27 [14:40:56] [Server thread/DEBUG]: #0 src/pocketmine/inventory/BaseInventory(439): pocketmine\inventory\DoubleChestInventory->getContents(boolean 1)
2018-10-27 [14:40:56] [Server thread/DEBUG]: #1 src/pocketmine/Player(3874): pocketmine\inventory\BaseInventory->sendContents(array Array())
2018-10-27 [14:40:56] [Server thread/DEBUG]: #2 src/pocketmine/Player(2352): pocketmine\Player->sendAllInventories()
2018-10-27 [14:40:56] [Server thread/DEBUG]: #3 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(136): pocketmine\Player->handleInventoryTransaction(CortexPE\network\InventoryTransactionPacket object)
2018-10-27 [14:40:56] [Server thread/DEBUG]: #4 TeaSpoon_dev-252.phar/src/CortexPE/network/InventoryTransactionPacket(81): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleInventoryTransaction(CortexPE\network\InventoryTransactionPacket object)
2018-10-27 [14:40:56] [Server thread/DEBUG]: #5 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(96): CortexPE\network\InventoryTransactionPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
2018-10-27 [14:40:56] [Server thread/DEBUG]: #6 src/pocketmine/network/mcpe/protocol/BatchPacket(114): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(CortexPE\network\InventoryTransactionPacket object)
2018-10-27 [14:40:56] [Server thread/DEBUG]: #7 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(96): pocketmine\network\mcpe\protocol\BatchPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
2018-10-27 [14:40:56] [Server thread/DEBUG]: #8 src/pocketmine/Player(3060): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
2018-10-27 [14:40:56] [Server thread/DEBUG]: #9 src/pocketmine/network/mcpe/RakLibInterface(161): pocketmine\Player->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
2018-10-27 [14:40:56] [Server thread/DEBUG]: #10 vendor/pocketmine/raklib/src/server/ServerHandler(98): pocketmine\network\mcpe\RakLibInterface->handleEncapsulated(string 31.32.XXX.158 58186, raklib\protocol\EncapsulatedPacket object, integer 0)
2018-10-27 [14:40:56] [Server thread/DEBUG]: #11 src/pocketmine/network/mcpe/RakLibInterface(102): raklib\server\ServerHandler->handlePacket()
2018-10-27 [14:40:56] [Server thread/DEBUG]: #12 src/pocketmine/network/Network(94): pocketmine\network\mcpe\RakLibInterface->process()
2018-10-27 [14:40:56] [Server thread/DEBUG]: #13 src/pocketmine/network/mcpe/RakLibInterface(92): pocketmine\network\Network->processInterface(pocketmine\network\mcpe\RakLibInterface object)
2018-10-27 [14:40:56] [Server thread/DEBUG]: #14 vendor/pocketmine/snooze/src/SleeperHandler(120): pocketmine\network\mcpe\RakLibInterface->pocketmine\network\mcpe\{closure}()
2018-10-27 [14:40:56] [Server thread/DEBUG]: #15 vendor/pocketmine/snooze/src/SleeperHandler(82): pocketmine\snooze\SleeperHandler->processNotifications()
2018-10-27 [14:40:56] [Server thread/DEBUG]: #16 src/pocketmine/Server(2268): pocketmine\snooze\SleeperHandler->sleepUntil(double 1540644055.5316)
2018-10-27 [14:40:56] [Server thread/DEBUG]: #17 src/pocketmine/Server(2135): pocketmine\Server->tickProcessor()
2018-10-27 [14:40:56] [Server thread/DEBUG]: #18 src/pocketmine/Server(1701): pocketmine\Server->start()
2018-10-27 [14:40:56] [Server thread/DEBUG]: #19 src/pocketmine/PocketMine(249): pocketmine\Server->__construct(BaseClassLoader object, pocketmine\utils\MainLogger object, string /home/myserver/, string /home/myserver/plugins/)
2018-10-27 [14:40:56] [Server thread/DEBUG]: #20 /home/myserver/PocketMine-MP.phar(1): require(string phar:///home/myserver/PocketMine-MP.phar/src/pocketmine/PocketMine.php)
2018-10-27 [14:40:56] [RakLibServer thread/NOTICE]: Blocked 31.32.XXX.158 for 5 seconds
2018-10-27 [13:47:13] [Server thread/CRITICAL]: Error: "Call to a member function getHolder() on null" (EXCEPTION) in "src/pocketmine/inventory/DoubleChestInventory" at line 59
2018-10-27 [13:47:13] [Server thread/DEBUG]: #0 src/pocketmine/inventory/ContainerInventory(46): pocketmine\inventory\DoubleChestInventory->getHolder()
2018-10-27 [13:47:13] [Server thread/DEBUG]: #1 src/pocketmine/inventory/ChestInventory(65): pocketmine\inventory\ContainerInventory->onOpen(pocketmine\Player object)
2018-10-27 [13:47:13] [Server thread/DEBUG]: #2 src/pocketmine/inventory/DoubleChestInventory(114): pocketmine\inventory\ChestInventory->onOpen(pocketmine\Player object)
2018-10-27 [13:47:13] [Server thread/DEBUG]: #3 src/pocketmine/inventory/BaseInventory(406): pocketmine\inventory\DoubleChestInventory->onOpen(pocketmine\Player object)
2018-10-27 [13:47:13] [Server thread/DEBUG]: #4 src/pocketmine/Player(3824): pocketmine\inventory\BaseInventory->open(pocketmine\Player object)
2018-10-27 [13:47:13] [Server thread/DEBUG]: #5 src/pocketmine/block/Chest(122): pocketmine\Player->addWindow(pocketmine\inventory\DoubleChestInventory object)
2018-10-27 [13:47:13] [Server thread/DEBUG]: #6 src/pocketmine/level/Level(1787): pocketmine\block\Chest->onActivate(pocketmine\item\Sword object, pocketmine\Player object)
2018-10-27 [13:47:13] [Server thread/DEBUG]: #7 src/pocketmine/Player(2375): pocketmine\level\Level->useItemOn(pocketmine\math\Vector3 object, pocketmine\item\Sword object, integer 1, pocketmine\math\Vector3 object, pocketmine\Player object, boolean 1)
2018-10-27 [13:47:13] [Server thread/DEBUG]: #8 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(136): pocketmine\Player->handleInventoryTransaction(CortexPE\network\InventoryTransactionPacket object)
2018-10-27 [13:47:13] [Server thread/DEBUG]: #9 TeaSpoon_dev-252.phar/src/CortexPE/network/InventoryTransactionPacket(81): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleInventoryTransaction(CortexPE\network\InventoryTransactionPacket object)
2018-10-27 [13:47:13] [Server thread/DEBUG]: #10 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(96): CortexPE\network\InventoryTransactionPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
2018-10-27 [13:47:13] [Server thread/DEBUG]: #11 src/pocketmine/network/mcpe/protocol/BatchPacket(114): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(CortexPE\network\InventoryTransactionPacket object)
2018-10-27 [13:47:13] [Server thread/DEBUG]: #12 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(96): pocketmine\network\mcpe\protocol\BatchPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
2018-10-27 [13:47:13] [Server thread/DEBUG]: #13 src/pocketmine/Player(3060): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
2018-10-27 [13:47:13] [Server thread/DEBUG]: #14 src/pocketmine/network/mcpe/RakLibInterface(161): pocketmine\Player->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
2018-10-27 [13:47:13] [Server thread/DEBUG]: #15 vendor/pocketmine/raklib/src/server/ServerHandler(98): pocketmine\network\mcpe\RakLibInterface->handleEncapsulated(string 31.32.XXX.158 41221, raklib\protocol\EncapsulatedPacket object, integer 0)
2018-10-27 [13:47:13] [Server thread/DEBUG]: #16 src/pocketmine/network/mcpe/RakLibInterface(102): raklib\server\ServerHandler->handlePacket()
2018-10-27 [13:47:13] [Server thread/DEBUG]: #17 src/pocketmine/network/Network(94): pocketmine\network\mcpe\RakLibInterface->process()
2018-10-27 [13:47:13] [Server thread/DEBUG]: #18 src/pocketmine/network/mcpe/RakLibInterface(92): pocketmine\network\Network->processInterface(pocketmine\network\mcpe\RakLibInterface object)
2018-10-27 [13:47:13] [Server thread/DEBUG]: #19 vendor/pocketmine/snooze/src/SleeperHandler(120): pocketmine\network\mcpe\RakLibInterface->pocketmine\network\mcpe\{closure}()
2018-10-27 [13:47:13] [Server thread/DEBUG]: #20 vendor/pocketmine/snooze/src/SleeperHandler(82): pocketmine\snooze\SleeperHandler->processNotifications()
2018-10-27 [13:47:13] [Server thread/DEBUG]: #21 src/pocketmine/Server(2268): pocketmine\snooze\SleeperHandler->sleepUntil(double 1540640833.1592)
2018-10-27 [13:47:13] [Server thread/DEBUG]: #22 src/pocketmine/Server(2135): pocketmine\Server->tickProcessor()
2018-10-27 [13:47:13] [Server thread/DEBUG]: #23 src/pocketmine/Server(1701): pocketmine\Server->start()
2018-10-27 [13:47:13] [Server thread/DEBUG]: #24 src/pocketmine/PocketMine(249): pocketmine\Server->__construct(BaseClassLoader object, pocketmine\utils\MainLogger object, string /home/myserver/, string /home/myserver/plugins/)
2018-10-27 [13:47:13] [Server thread/DEBUG]: #25 /home/myserver/PocketMine-MP.phar(1): require(string phar:///home/myserver/PocketMine-MP.phar/src/pocketmine/PocketMine.php)
2018-10-27 [13:47:13] [RakLibServer thread/NOTICE]: Blocked 31.32.XXX.158 for 5 seconds
2018-10-27 [14:35:22] [Server thread/CRITICAL]: Error: "Call to a member function getHolder() on null" (EXCEPTION) in "src/pocketmine/inventory/DoubleChestInventory" at line 122
2018-10-27 [14:35:22] [Server thread/DEBUG]: #0 src/pocketmine/inventory/BaseInventory(412): pocketmine\inventory\DoubleChestInventory->onClose(pocketmine\Player object)
2018-10-27 [14:35:22] [Server thread/DEBUG]: #1 src/pocketmine/Player(3851): pocketmine\inventory\BaseInventory->close(pocketmine\Player object)
2018-10-27 [14:35:22] [Server thread/DEBUG]: #2 src/pocketmine/Player(3868): pocketmine\Player->removeWindow(pocketmine\inventory\DoubleChestInventory object, boolean )
2018-10-27 [14:35:22] [Server thread/DEBUG]: #3 src/pocketmine/Player(3707): pocketmine\Player->removeAllWindows()
2018-10-27 [14:35:22] [Server thread/DEBUG]: #4 essentialsTP_dev-31.phar/src/essentialsTP/essentialsTP(1142): pocketmine\Player->teleport(pocketmine\level\Position object)
2018-10-27 [14:35:22] [Server thread/DEBUG]: #5 src/pocketmine/command/PluginCommand(58): essentialsTP\essentialsTP->onCommand(pocketmine\Player object, pocketmine\command\PluginCommand object, string spawn, array Array())
2018-10-27 [14:35:22] [Server thread/DEBUG]: #6 src/pocketmine/command/SimpleCommandMap(258): pocketmine\command\PluginCommand->execute(pocketmine\Player object, string spawn, array Array())
2018-10-27 [14:35:22] [Server thread/DEBUG]: #7 src/pocketmine/Server(1956): pocketmine\command\SimpleCommandMap->dispatch(pocketmine\Player object, string spawn)
2018-10-27 [14:35:22] [Server thread/DEBUG]: #8 src/pocketmine/Player(2193): pocketmine\Server->dispatchCommand(pocketmine\Player object, string spawn)
2018-10-27 [14:35:22] [Server thread/DEBUG]: #9 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(226): pocketmine\Player->chat(string /spawn)
2018-10-27 [14:35:22] [Server thread/DEBUG]: #10 src/pocketmine/network/mcpe/protocol/CommandRequestPacket(54): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleCommandRequest(pocketmine\network\mcpe\protocol\CommandRequestPacket object)
2018-10-27 [14:35:22] [Server thread/DEBUG]: #11 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(96): pocketmine\network\mcpe\protocol\CommandRequestPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
2018-10-27 [14:35:22] [Server thread/DEBUG]: #12 src/pocketmine/network/mcpe/protocol/BatchPacket(114): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\CommandRequestPacket object)
2018-10-27 [14:35:22] [Server thread/DEBUG]: #13 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(96): pocketmine\network\mcpe\protocol\BatchPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
2018-10-27 [14:35:22] [Server thread/DEBUG]: #14 src/pocketmine/Player(3060): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
2018-10-27 [14:35:22] [Server thread/DEBUG]: #15 src/pocketmine/network/mcpe/RakLibInterface(161): pocketmine\Player->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
2018-10-27 [14:35:22] [Server thread/DEBUG]: #16 vendor/pocketmine/raklib/src/server/ServerHandler(98): pocketmine\network\mcpe\RakLibInterface->handleEncapsulated(string 31.32.XXX.158 58186, raklib\protocol\EncapsulatedPacket object, integer 0)
2018-10-27 [14:35:22] [Server thread/DEBUG]: #17 src/pocketmine/network/mcpe/RakLibInterface(102): raklib\server\ServerHandler->handlePacket()
2018-10-27 [14:35:22] [Server thread/DEBUG]: #18 src/pocketmine/network/Network(94): pocketmine\network\mcpe\RakLibInterface->process()
2018-10-27 [14:35:22] [Server thread/DEBUG]: #19 src/pocketmine/network/mcpe/RakLibInterface(92): pocketmine\network\Network->processInterface(pocketmine\network\mcpe\RakLibInterface object)
2018-10-27 [14:35:22] [Server thread/DEBUG]: #20 vendor/pocketmine/snooze/src/SleeperHandler(120): pocketmine\network\mcpe\RakLibInterface->pocketmine\network\mcpe\{closure}()
2018-10-27 [14:35:22] [Server thread/DEBUG]: #21 vendor/pocketmine/snooze/src/SleeperHandler(82): pocketmine\snooze\SleeperHandler->processNotifications()
2018-10-27 [14:35:22] [Server thread/DEBUG]: #22 src/pocketmine/Server(2268): pocketmine\snooze\SleeperHandler->sleepUntil(double 1540643721.3746)
2018-10-27 [14:35:22] [Server thread/DEBUG]: #23 src/pocketmine/Server(2135): pocketmine\Server->tickProcessor()
2018-10-27 [14:35:22] [Server thread/DEBUG]: #24 src/pocketmine/Server(1701): pocketmine\Server->start()
2018-10-27 [14:35:22] [Server thread/DEBUG]: #25 src/pocketmine/PocketMine(249): pocketmine\Server->__construct(BaseClassLoader object, pocketmine\utils\MainLogger object, string /home/myserver/, string /home/myserver/plugins/)
2018-10-27 [14:35:22] [Server thread/DEBUG]: #26 /home/myserver/PocketMine-MP.phar(1): require(string phar:///home/myserver/PocketMine-MP.phar/src/pocketmine/PocketMine.php)
larryTheCoder commented 5 years ago

Hmm I think its neither PocketMine issue or other plugin issues :thinking:

But its definitely not TeaSpoon issue. I see there is a TeaSpoon on that stack trace but that is not causing the issue. Its just packets. Nothing else.

teracube commented 5 years ago

error ... at line 76 is a new issue appeared with PMMP v1604 and Teaspoon v252.

error ... at line 59 and error... at line 122 are olders issues.

teracube commented 5 years ago

@CortexPE @larryTheCoder

is this the PMMP fix you are waiting for ? thanks

https://github.com/pmmp/PocketMine-MP/issues/2502 https://github.com/pmmp/PocketMine-MP/issues/2503

CortexPE commented 5 years ago

well right now, its not in the releases... please wait for it. then check if it does fix the issue.

teracube commented 5 years ago

good news need to be confirm

i think this issue is solved on latest stable pmmp construction : https://jenkins.pmmp.io/job/PocketMine-MP/1642/artifact/PocketMine-MP.phar

i'll continue to test it but since 24 hours no error DoubleChest at line 59 /76/122...

Infernus101 commented 5 years ago

Which commit fixes it? @teracube

teracube commented 5 years ago

@Infernus101

please test hoppers with :

latest stable construction PMMP https://jenkins.pmmp.io/job/PocketMine-MP/1642/

there is no commit reference of #1642 ???? https://jenkins.pmmp.io/job/PocketMine-MP/changes

lastest Teaspoon version https://poggit.pmmp.io/r/44584/TeaSpoon_dev-256.phar

tell us if you have error/crash Doublechest at line 63... with this build

Infernus101 commented 5 years ago

i added this commit pmmp/PocketMine-MP#2502, lets see if its fixed @teracube

teracube commented 5 years ago

@Infernus101 do you know how to reproduce crash/issue DoubleChest at line 63 ??? thanks

Infernus101 commented 5 years ago

@Infernus101 do you know how to reproduce crash/issue DoubleChest at line 63 ??? thanks

No i dont, but i m getting no errors for hoppers by adding that commit ^

teracube commented 5 years ago

@infernus101 me too, no errors good