CortexPE / TeaSpoon

☕ A PLUGIN to Extend PMMP's Functionality without completely changing it.
GNU Affero General Public License v3.0
144 stars 100 forks source link

Kicks user for internal server error when using crafting table. #356

Closed ZandercraftGames closed 5 years ago

ZandercraftGames commented 5 years ago

Whenever I make a cobblestone slab using the recipe book, it kicks me saying "Internal Server Error".

[21:46:42] [Server thread/CRITICAL]: ErrorException: "Uninitialized string offset: 4625" (EXCEPTION) in "vendor/pocketmine/binaryutils/src/Binary" at line 448
[21:46:42] [Server thread/DEBUG]: #0 vendor/pocketmine/binaryutils/src/Binary(448): pocketmine\utils\Utils::errorExceptionHandler(integer 8, string Uninitialized string offset: 4625, string phar://C:/Users/Zander Maitland/Desktop/Pocketmine/PocketMine-MP.phar/vendor/pocketmine/binaryutils/src/Binary.php, integer 448, array Array())
[21:46:42] [Server thread/DEBUG]: #1 vendor/pocketmine/binaryutils/src/Binary(430): pocketmine\utils\Binary::readUnsignedVarInt(string ...d.............&.........., integer 4626)
[21:46:42] [Server thread/DEBUG]: #2 vendor/pocketmine/binaryutils/src/BinaryStream(239): pocketmine\utils\Binary::readVarInt(string ...d.............&.........., integer 4626)
[21:46:42] [Server thread/DEBUG]: #3 src/pocketmine/network/mcpe/NetworkBinaryStream(87): pocketmine\utils\BinaryStream->getVarInt()
[21:46:42] [Server thread/DEBUG]: #4 TeaSpoon_dev-258.phar/src/CortexPE/network/types/NetworkInventoryAction(135): pocketmine\network\mcpe\NetworkBinaryStream->getSlot()
[21:46:42] [Server thread/DEBUG]: #5 TeaSpoon_dev-258.phar/src/CortexPE/network/InventoryTransactionPacket(88): CortexPE\network\types\NetworkInventoryAction->read(CortexPE\network\InventoryTransactionPacket object)
[21:46:42] [Server thread/DEBUG]: #6 src/pocketmine/network/mcpe/protocol/DataPacket(74): CortexPE\network\InventoryTransactionPacket->decodePayload()
[21:46:42] [Server thread/DEBUG]: #7 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(90): pocketmine\network\mcpe\protocol\DataPacket->decode()
[21:46:42] [Server thread/DEBUG]: #8 src/pocketmine/network/mcpe/protocol/BatchPacket(114): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(CortexPE\network\InventoryTransactionPacket object)
[21:46:42] [Server thread/DEBUG]: #9 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(98): pocketmine\network\mcpe\protocol\BatchPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
[21:46:42] [Server thread/DEBUG]: #10 src/pocketmine/Player(3044): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
[21:46:42] [Server thread/DEBUG]: #11 src/pocketmine/network/mcpe/RakLibInterface(162): pocketmine\Player->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
[21:46:42] [Server thread/DEBUG]: #12 vendor/pocketmine/raklib/src/server/ServerHandler(98): pocketmine\network\mcpe\RakLibInterface->handleEncapsulated(string 192.168.2.165 63450, raklib\protocol\EncapsulatedPacket object, integer 0)
[21:46:42] [Server thread/DEBUG]: #13 src/pocketmine/network/mcpe/RakLibInterface(102): raklib\server\ServerHandler->handlePacket()
[21:46:42] [Server thread/DEBUG]: #14 src/pocketmine/network/Network(94): pocketmine\network\mcpe\RakLibInterface->process()
[21:46:42] [Server thread/DEBUG]: #15 src/pocketmine/network/mcpe/RakLibInterface(92): pocketmine\network\Network->processInterface(pocketmine\network\mcpe\RakLibInterface object)
[21:46:42] [Server thread/DEBUG]: #16 vendor/pocketmine/snooze/src/SleeperHandler(120): pocketmine\network\mcpe\RakLibInterface->pocketmine\network\mcpe\{closure}()
[21:46:42] [Server thread/DEBUG]: #17 vendor/pocketmine/snooze/src/SleeperHandler(82): pocketmine\snooze\SleeperHandler->processNotifications()
[21:46:42] [Server thread/DEBUG]: #18 src/pocketmine/Server(2278): pocketmine\snooze\SleeperHandler->sleepUntil(double 1545623202.4265)
[21:46:42] [Server thread/DEBUG]: #19 src/pocketmine/Server(2139): pocketmine\Server->tickProcessor()
[21:46:42] [Server thread/DEBUG]: #20 src/pocketmine/Server(1715): pocketmine\Server->start()
[21:46:42] [Server thread/DEBUG]: #21 src/pocketmine/PocketMine(249): pocketmine\Server->__construct(BaseClassLoader object, pocketmine\utils\MainLogger object, string C:\Users\Zander Maitland\Desktop\Pocketmine\, string C:\Users\Zander Maitland\Desktop\Pocketmine\plugins\)
[21:46:42] [Server thread/DEBUG]: #22 C:/Users/Zander Maitland/Desktop/Pocketmine/PocketMine-MP.phar(1): require(string phar://C:/Users/Zander Maitland/Desktop/Pocketmine/PocketMine-MP.phar/src/pocketmine/PocketMine.php)
[21:46:42] [Server thread/INFO]: [Staff] <Staff> ZandercraftYT disconnected from the server.
[21:46:42] [Server thread/INFO]: [21:46:42] ZandercraftYT has left the game
ZandercraftGames commented 5 years ago

Well it doesnt crash the server, just kicks the user. Also, it is whenever someone uses the crafting table, not just recipe book. Second someone puts an item into it.

ZandercraftGames commented 5 years ago

Steps to reproduce:

  1. Open crafting table in survival.
  2. Try to craft something
  3. Get kicked for internal server error.
ZandercraftGames commented 5 years ago

@CortexPE Please help. This is critical.

ZandercraftGames commented 5 years ago

image

ZandercraftGames commented 5 years ago

It also blocks the IP for 5 seconds.

ZandercraftGames commented 5 years ago

[22:02:47] [RakLibServer thread/NOTICE]: Blocked 192.168.2.165 for 5 seconds

hqn21 commented 5 years ago

same problem

MikeyHampton commented 5 years ago

Same

On Mon, Dec 31, 2018 at 2:57 AM 零 ZeroK notifications@github.com wrote:

same problem

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CortexPE/TeaSpoon/issues/356#issuecomment-450617660, or mute the thread https://github.com/notifications/unsubscribe-auth/ArDl4ZOXazSNUCU1aWZBi9kOx8XJOsk3ks5u-cNpgaJpZM4ZgGrz .

MikeyHampton commented 5 years ago

This can be easily fixed uh

On Mon, Dec 31, 2018 at 2:58 AM Mikey Hampton mikeyhamptoncontact@gmail.com wrote:

Same

On Mon, Dec 31, 2018 at 2:57 AM 零 ZeroK notifications@github.com wrote:

same problem

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CortexPE/TeaSpoon/issues/356#issuecomment-450617660, or mute the thread https://github.com/notifications/unsubscribe-auth/ArDl4ZOXazSNUCU1aWZBi9kOx8XJOsk3ks5u-cNpgaJpZM4ZgGrz .

hqn21 commented 5 years ago

How to fix it?

ZandercraftGames commented 5 years ago

Yeh how do you fix it @cortexpe help

CortexPE commented 5 years ago

Does it happen on the latest version of TeaSpoon?

On Mon, Dec 31, 2018, 10:34 PM Zander <notifications@github.com wrote:

Yeh how do you fix it @CortexPE https://github.com/CortexPE help

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CortexPE/TeaSpoon/issues/356#issuecomment-450652396, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ8IFLNFtlodQGpZk8kErds_jZgGMMOyks5u-iBlgaJpZM4ZgGrz .

ZandercraftGames commented 5 years ago

@cortexpe I'm pretty sure that's what I'm running. When was the last time an update was released?

CortexPE commented 5 years ago

Just use the latest version, the current version doesn't even call getSlot() on line 135

On Tue, Jan 1, 2019, 3:12 AM Zander <notifications@github.com wrote:

@CortexPE https://github.com/CortexPE I'm pretty sure that's what I'm running. When was the last time an update was released?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CortexPE/TeaSpoon/issues/356#issuecomment-450681729, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ8IFCBqhRU4dK0qk-GCNlpgHy1LPn6Wks5u-mGrgaJpZM4ZgGrz .

CortexPE commented 5 years ago

So I really think it's because you're using an outdated version

On Tue, Jan 1, 2019, 3:14 AM CortexPE <mcpe4life62@gmail.com wrote:

Just use the latest version, the current version doesn't even call getSlot() on line 135

On Tue, Jan 1, 2019, 3:12 AM Zander <notifications@github.com wrote:

@CortexPE https://github.com/CortexPE I'm pretty sure that's what I'm running. When was the last time an update was released?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CortexPE/TeaSpoon/issues/356#issuecomment-450681729, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ8IFCBqhRU4dK0qk-GCNlpgHy1LPn6Wks5u-mGrgaJpZM4ZgGrz .

ZandercraftGames commented 5 years ago

I will check @CortexPE

ZandercraftGames commented 5 years ago

I was using dev-258

ZandercraftGames commented 5 years ago

Ummmm… @CortexPE

[13:22:06] [Server thread/ERROR]: Could not load plugin 'TeaSpoon': Incompatible API version (plugin requires one of: 3.5.1)
CortexPE commented 5 years ago

We're currently at dev-265 rn

On Tue, Jan 1, 2019, 3:22 AM Zander <notifications@github.com wrote:

Ummmm… @CortexPE https://github.com/CortexPE [13:22:06] [Server thread/ERROR]: Could not load plugin 'TeaSpoon': Incompatible API version (plugin requires one of: 3.5.1)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CortexPE/TeaSpoon/issues/356#issuecomment-450682604, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ8IFAm62ah4YQlRTyeYh6hniCgakES9ks5u-mQHgaJpZM4ZgGrz .

ZandercraftGames commented 5 years ago

@CortexPE Hey... What changes happened to configs?

CortexPE commented 5 years ago

Check the commit history of /resources/config.yml

On Tue, Jan 1, 2019, 3:26 AM Zander <notifications@github.com wrote:

@CortexPE https://github.com/CortexPE Hey... What changes happened to configs?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CortexPE/TeaSpoon/issues/356#issuecomment-450682858, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ8IFHkZqjuTbUslbIAg5RBK6S3FEkeWks5u-mTRgaJpZM4ZgGrz .