search

Cortys / comic-backup

Back up your comics as CBZ.
https://cmxlgy.wordpress.com
GNU General Public License v3.0
295 stars 33 forks source link

Crash while scanning #56

Open shinji257 opened 8 years ago

shinji257 commented 8 years ago

This actually happens randomly for the most part. When it does I usually just re-queue it and have it try again, however, this one title it seems to be happening consistently.

The title is The Last West #1 and it is free on Comixology.

Store link: https://www.comixology.com/The-Last-West-1/digital-comic/49569

Would you be able to check to see what's happening? Maybe it will show why it crashes randomly elsewhere as well.

For reference: OS: Ubuntu 16.04 Browser: Chromium 51.0.2704.79 Connection: Multi-gigabit speeds.... It's a VPS server with remote desktop.

Cortys commented 8 years ago

Hi! Thanks for the report!

I just scanned the comic you mentioned three times in a row without any issues.

Could you send me your configuration (found at the options page of the extension)? Also could you try disabling all other extensions to make sure that there isn't something else interfering?

shinji257 commented 8 years ago

There are no other extensions installed (screenshot below) image

Extension configuration. image image

shinji257 commented 8 years ago

Ok. I did a test and I switched temporary storage from FS to RAM (which is the default anyways) and it went through just fine. There may be a bug floating around in the FS routines and might explain why I got random crashes elsewhere. As soon as I switched it back to FS it crashed the tab again.

Cortys commented 8 years ago

You are probably right. The FS storage implementation uses the LocalFileSystem API, which always was non-standard and a bit buggy.

On OS X it works fine for me. Using Linux I just reproduced the issues you described.

For the next release I'll find out if by now there are better ways to implement file system based temp storage.

shinji257 commented 8 years ago

Alright. Well, thanks for confirming. In the meantime I found large comics do need the FS option to work since I just crashed my VPS using the RAM option and trying to scan a huge sampler manga so what I'll probably do is set it to use FS then switch to RAM for problematic ones.

psychedelic2099 commented 7 years ago

"hey guys the issue with crashing is down to the extension taking up all the ram the longer its running, im on 8gb of ram so it normally crashes around 100 or so pages depending on the format. this is for 4.20 it does this whether its going by cbz or jpg files, most big books take 2 or 3 tries with it set to "start at currently open page" anyway for you to fix this memory leak?"

ok updating google chrome has fixed this issue, if your still having issues with 4.20 then go to the settings, about then update chrome.