Feature request - toggle Weather to 3rd line (below Date)

[softweaprograma]

I looked in Play store comments and here and did not find this as a request... so thought I'd put it in. Thanks. I really like the watch face.

[CorvetteCole]

I am considering this but I do not think I will implement it. It does not really fit my design idea for the watch face (to match the pixels). Although this design does present some benefits in looking less cluttered

[softweaprograma]

Ok, Thanks for the response. Hopefully some day you will consider it. I think it makes both the date and weather more readable and more aesthetically pleasing.

[softweaprograma]

Hi, I forked your code and made the changes in my branch for the feature request. Thank you so very much for releasing the code on github, I learned a lot looking at your code, great job I must say. My code not as good or as clean as yours and there is still some bugs...but does what I was proposing. I am using my updated version on my watch. Great job again and thank you so very much for this very awesome watchface. I have been looking for this exact design for years! (I have owned 3 android based watches). If you ever want to see my updates you can find those in my fork. https://github.com/softweaprograma/PixelWatchFace

[CorvetteCole]

Hi, can you open up a pull request? I'd be happy to accept this code commit in to the main app. I'm glad you got it working! You will be the first external contributor to the app :)

[softweaprograma]

Hi, Sure, will do... it will definitely need some clean up, I still have some dead (commented) code in there and the toggles may need some minor adjustments... Just want you to know its not perfect, if you are still okay with that, I will do the pull request asap.

[CorvetteCole]

I'm planning on putting it in its own branch and then eventually merging with master so no biggie. But also you can take your time if you'd rather clean up the code first!

On Tue, May 14, 2019, 12:59 PM Anthony G notifications@github.com wrote:

Hi, Sure, will do... it will definitely need some clean up, I still have some dead (commented) code in there and the toggles may need some minor adjustments... Just want you to know its not perfect, if you are still okay with that, I will do the pull request asap.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CorvetteCole/PixelWatchFace/issues/5?email_source=notifications&email_token=AESS5DN6GMP3TLLKQHAB2KDPVLVW7A5CNFSM4HJOXCWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVMD4EY#issuecomment-492322323, or mute the thread https://github.com/notifications/unsubscribe-auth/AESS5DIOG3CHY75AQ4HSFITPVLVW7ANCNFSM4HJOXCWA .

[softweaprograma]

Ok... I will do the pull request. Thanks.

[softweaprograma]

Done.

[davwheat]

Could this be re-opened?

I'd love for this to be a toggle option. I know it doesn't fit the actual pixel lock screen but a smartwatch doesn't have the same screen size as a pixel, so space is much more valuable!

Putting the date and weather on one line looks to cluttered, especially without a separator of some sort between them.

Just like you've recently added the battery indicator (on GitHub and not Play Store!), you could add this just by modifying the code on the 3rd line branch to check for a boolean in the shared preferences.

[CorvetteCole]

@davwheat is this still desired? considering implementation now

[davwheat]

I mean I'd love to have it as an option. I just need to buy a new watch to use it :P

[CorvetteCole]

this will be included in 1.7.0