Corvia / django-tenant-users

Adds global user authentication and tenant-specific permissions to django-tenants.

https://django-tenant-users.rtfd.io

MIT License

333 stars 64 forks source link

BREAKING CHANGES::Now returning created tenant from provision_tenant utility function #607

Closed Wizely99 closed 3 months ago

Wizely99 commented 3 months ago

I'm helping!

Checklist

[x] I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc.)
[x] I have created at least one test case for the changes I have made
[x] I have updated the documentation for the changes I have made
[ ] I have added my changes to the CHANGELOG.md

Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[x] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] Documentation content changes
[ ] Other (please describe):

Related issue(s)

Other Information

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.77%. Comparing base (2b2c385) to head (a34ee34). Report is 91 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #607 +/- ## =========================================== + Coverage 88.36% 99.77% +11.40% =========================================== Files 18 26 +8 Lines 619 875 +256 Branches 116 144 +28 =========================================== + Hits 547 873 +326 + Misses 62 1 -61 + Partials 10 1 -9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Wizely99 commented 3 months ago

I am working on the docs but before I would like to get the feedback from you guys. There was an issue about returning the tenant from the provision_tenant function but I think it was closed for some reason. This PR has addressed.I am eager to help more

Dresdn commented 3 months ago

This is great @Wizely99! I've had this as a todo for some time, so I appreciate the work put into it. I don't really have much feedback on it, but will merge in once the docs are done.

Thank you!

Wizely99 commented 3 months ago

Hello @Dresdn . I've updated the docs you can check them out..

Dresdn commented 3 months ago

Hi @Wizely99. The docs look good, and good call on missing a RST formatter. Since you mentioned rstfmt, I added that to the tool.poetry.group.test.dependencies and then added a check to the test workflow.

Thank you for the contribution!

Wizely99 commented 3 months ago

@Dresdn You're welcome! Glad I could help out.