Revert "Enable build with -fvisibility=hidden"

Corvusoft / restbed

Corvusoft's Restbed framework brings asynchronous RESTful functionality to C++14 applications.

http://www.corvusoft.co.uk

Other

1.93k stars 379 forks source link

Revert "Enable build with -fvisibility=hidden" #525

Closed ben-crowhurst closed 2 years ago

ben-crowhurst commented 2 years ago

Reverts Corvusoft/restbed#49

 96/116 Test  #96: yield_callback_leads_to_service_crash_regression_test_suite ................Exit code 0xc0000409
***Exception:   0.18 sec

99% tests passed, 1 tests failed out of 116
Total Test time (real) =  36.23 sec
The following tests FAILED:
     96 - yield_callback_leads_to_service_crash_regression_test_suite (Exit code 0xc0000409
)
Errors while running CTest
Command exited with code 8

log.txt

bansan85 commented 2 years ago

Hi, Are you sure this is related to the commit -fvisibility=hidden ? The suite test succeeded twice (once with the pull request, once with the merge). Maybe it's a random bug ?

ben-crowhurst commented 2 years ago

Hey @bansan85, this was raised as a precaution, was meaning to remove it and got distracted; sorry for the cognitive load.