CorwinDev / Discord-Bot

Discord Bot with over 400 commands and made for large servers
MIT License
686 stars 612 forks source link

Made Webhooks more Easily Configurable #79

Closed HenryCpr closed 1 year ago

HenryCpr commented 1 year ago

Made it so the webhook url's must only be put in webhooks.json and not in the actual file to make it more easy for configuration

CorwinDev commented 1 year ago

Thanks, but what did you do to src/commands/developers/args.js ?

HenryCpr commented 1 year ago

I just took off the spaces from the images as it didn't work for me with the spaces and also malfunctioned on replit.

CorwinDev commented 1 year ago

That whole url isn't even working so, if you revert that one ill merge it :)

HenryCpr commented 1 year ago

Will do that rn and just realized I deleted a essential webhook the startLogs one so I'll re-add that too.

HenryCpr commented 1 year ago

Fixed it

CorwinDev commented 1 year ago

And one thing more, add it to bot.js and index.js 🙂

For dynamically setting it via .env

HenryCpr commented 1 year ago

I'm sorry can you be more specific? I'm kinda lost in ur words lmao

HenryCpr commented 1 year ago

Do you want startLogs to be configured to .env?

CorwinDev commented 1 year ago

https://github.com/CorwinDev/Discord-Bot/blob/e9aa9cabaef3cfe94d802dc48c5356ccaedaa2a1/src/bot.js#LL116C20-L116C20 and https://github.com/CorwinDev/Discord-Bot/blob/e9aa9cabaef3cfe94d802dc48c5356ccaedaa2a1/src/index.js#L18

HenryCpr commented 1 year ago

Ahh i see I'll do it

HenryCpr commented 1 year ago

I just updated it do you mean it like that?

CorwinDev commented 1 year ago

No, you just need to add the names to the array mentioned earlier

HenryCpr commented 1 year ago

Ok, i'm dumb i just realised what you actually wanted me to fix

HenryCpr commented 1 year ago

Ok Fixed finally