add minimum pandas version

CorySimon / pyIAST

Ideal Adsorbed Solution Theory

MIT License

47 stars 32 forks source link

add minimum pandas version #8

Closed ltalirz closed 5 years ago

ltalirz commented 5 years ago

switch from argmin to idxmin

CorySimon commented 5 years ago

thanks, this looks good. if param not in list(self.param_guess.keys()): just out of curiosity, why was this change necessary? it works for me with and without the list() encapsulating self.param_guess.keys().

ltalirz commented 5 years ago

just out of curiosity, why was this change necessary?

I believe the reason is that dict.keys() returns an iterable in python3, while it returns a list in python2. For the in operator in an if statement this shouldn't be a problem, though, so python-modernize was probably just over-cautious.