search

Cosium / git-code-format-maven-plugin

A maven plugin that automatically deploys code formatters as pre-commit git hook
MIT License
200 stars 39 forks source link

Reformatting on Windows during pre commit hook causes the reformatted file to be restaged #227

Open mjuergens-cg opened 1 month ago

mjuergens-cg commented 1 month ago

What steps will reproduce the problem? Steps to reproduce the behavior:

  1. Git repo on Windows with autocrlf=true
  2. git-code-format-maven-plugin in 5.3 set up using Maven, Git hooks installed
  3. Change a file in the repo such that git-code-format-maven-plugin will reformat it
  4. Commit

What is the expected output? Commited, nothing more

What happens instead? git status show that the file is restaged (this time apparently due to changed line endings):

modified: src/x/y.java

I can see the original file has CRLF line endings, the temporary file has LF line endings and the restaged file has CRLF endings again.

When I recommit again the staged file (that is not to be reformatted then), the commit is successful without being restaged.

Environment:

Link to a git repository that can be cloned to reproduce the problem:

Additional context No problems when autocrlf=false

mjuergens-cg commented 1 month ago

Probably a duplicate of https://github.com/Cosium/git-code-format-maven-plugin/issues/96 - sorry :(