search

Cosium / spring-data-jpa-entity-graph

Spring Data JPA extension allowing full dynamic usage of EntityGraph on repositories
MIT License
469 stars 52 forks source link

Spring Data Commons 2.0.0 is not compatible #10

Closed marceloverdijk closed 7 years ago

marceloverdijk commented 7 years ago

In Spring Data Commons 2.0.0 (currently only milestones being released) QueryDslPredicateExecutor seems to be renamed to QuerydslPredicateExecutor.

Spring Boot 2.0 uses Spring Data 2.0 so currently there is no way to upgrade from Spring Boot 1.5.x to 2.0.

I don't know why they renamed it but it causes some incompatibilities unfortunately.

marceloverdijk commented 7 years ago

But it is related to DATACMNS-867 - Consistent non-capitalization of Querydsl.

Maybe good to do use the same naming for the spring-data-jpa-entity-graph project. That way you probably could also easily support both Spring data < 2.0 and >= 2.0.

mp911de commented 7 years ago

Spring Data 2.0 comes with a series of breaking changes (CrudRepository method renaming, restructuring of internal APIs). 2.0 isn't compatible with the 1.x line and requires some effort to upgrade.

reda-alaoui commented 7 years ago

Hello,

Thanks for reporting this. Indeed we have to start upgrading master branch to spring data 2.0.

As usual, PRs are welcomed until I find time to upgrade ;)

marceloverdijk commented 7 years ago

👍