Cosium / spring-data-jpa-entity-graph

Spring Data JPA extension allowing full dynamic usage of EntityGraph on repositories
MIT License
469 stars 52 forks source link

Update to Spring Data 2.0.0.RC3 #12

Closed marceloverdijk closed 6 years ago

marceloverdijk commented 6 years ago

This makes it easier for people to clone the repo and build spring-data-jpa-entity-graph:2.0.0-SNAPSHOT locally (as there is no release yet compatible with Spring Boot 2.0)

reda-alaoui commented 6 years ago

Hello @marceloverdijk ,

Thanks for the PR.

Travis is complaining about the new dependency. I guess you didn't have this issue?

marceloverdijk commented 6 years ago

Hi @reda-alaoui no I did't have this issue, probably because the Spring Data 2.0.0. RC3 artifacts were already in my local Maven repository.

I see Travis is trying to download it from https://repo.spring.io/libs-snapshot-local, and the milestones are stored in https://repo.spring.io/libs-milestone-local/.

I think you have to add that to your src/site/resources/settings.xml configuration and it should work.

reda-alaoui commented 6 years ago

Ok, can you add the milestone repository to src/site/resources/settings.xml to make the build pass?

marceloverdijk commented 6 years ago

I've added it but still fails. How does your project resolve the snapshot deps then?

I see this `before_install:

reda-alaoui commented 6 years ago

Correct. Let's merge it ;)

reda-alaoui commented 6 years ago

Build OK on master !

marceloverdijk commented 6 years ago

👍