search

Cosium / spring-data-jpa-entity-graph

Spring Data JPA extension allowing full dynamic usage of EntityGraph on repositories
MIT License
469 stars 52 forks source link

Spring Data 2.0 uses Optional<T> findOne #13

Closed marceloverdijk closed 6 years ago

marceloverdijk commented 6 years ago

The EntityGraphQuerydslPredicateExecutor currently uses the following signature:

T findOne(Predicate predicate, EntityGraph entityGraph);

In Spring Data 2.0 the {{QuerydslPredicateExecutor}} is changed to:

Optional<T> findOne(Predicate var1);

I think this library should upgrade to the Optional<T> as well for findOne.

marceloverdijk commented 6 years ago

Note EntityGraphJpaSpecificationExecutor already does this but EntityGraphQuerydslPredicateExecutor not yet.

reda-alaoui commented 6 years ago

Yep !