search

Cosium / spring-data-jpa-entity-graph

Spring Data JPA extension allowing full dynamic usage of EntityGraph on repositories
MIT License
469 stars 52 forks source link

Add equals/hashCode implementations to the EntityGraph classes #22

Closed thyming closed 5 years ago

thyming commented 5 years ago

Closes #21.

codecov-io commented 5 years ago

Codecov Report

Merging #22 into master will increase coverage by 1.05%. The diff coverage is 72.22%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #22      +/-   ##
============================================
+ Coverage     77.83%   78.89%   +1.05%     
- Complexity      102      116      +14     
============================================
  Files            22       22              
  Lines           361      379      +18     
  Branches         44       52       +8     
============================================
+ Hits            281      299      +18     
+ Misses           66       62       -4     
- Partials         14       18       +4
Impacted Files Coverage Δ Complexity Δ
...ta/jpa/entity/graph/domain/DynamicEntityGraph.java 72.22% <55.55%> (+16.66%) 9 <5> (+6) :arrow_up:
...data/jpa/entity/graph/domain/NamedEntityGraph.java 95% <88.88%> (-5%) 13 <7> (+7)
...a/jpa/entity/graph/domain/AbstractEntityGraph.java 68.42% <0%> (+10.52%) 6% <0%> (+1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f63315...233b32e. Read the comment docs.

reda-alaoui commented 5 years ago

Thank you @thyming . Could you add tests on the two classes?

thyming commented 5 years ago

Sure thing, done.

reda-alaoui commented 5 years ago

Thank you @thyming I am releasing right now.

thyming commented 5 years ago

Thanks!

On Thu, Dec 13, 2018 at 11:20 AM Réda Housni Alaoui < notifications@github.com> wrote:

Thank you @thyming https://github.com/thyming I am releasing right now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Cosium/spring-data-jpa-entity-graph/pull/22#issuecomment-447029267, or mute the thread https://github.com/notifications/unsubscribe-auth/ACHW6XuQ3n7LJkt5ecOe1MLzoWj9jmK8ks5u4n5kgaJpZM4ZP83B .

reda-alaoui commented 5 years ago

2.0.7 has been released.