search

Cosium / spring-data-jpa-entity-graph

Spring Data JPA extension allowing full dynamic usage of EntityGraph on repositories
MIT License
478 stars 49 forks source link

Update README.md #79

Closed NicoStrecker closed 1 year ago

NicoStrecker commented 1 year ago

Fix manual that new users have a smoother start with the library.

NicoStrecker commented 1 year ago

@reda-alaoui i hope you consider merging it.

reda-alaoui commented 1 year ago

I don't wish to parrot Spring Data JPA documentation in this project, because I won't maintain this kind of synchronisation.

Also, using the basePackage attribute is clearly optional. We can see the sample working without it. So it makes no sense to let a user think this is mandatory.

I understand that most Spring Boot users are clueless about @EnableJpaRepositories since the whole annotation declaration is optional in their context. On the other hand, non Spring Boot users had to use @EnableJpaRepositories to make their applications work with Spring Data JPA.

My conclusion is that the Quick start @EnableJpaRepositories section should be more geared toward Spring Boot users. https://github.com/Cosium/spring-data-jpa-entity-graph/commit/5a6104a4f9eab4c3489b248cba5ed90b6fbe902d should fix that without parroting Spring Data JPA documentation.