search

CosmWasm / cw-plus

Production Quality contracts under open source licenses
Apache License 2.0
511 stars 352 forks source link

cw20-ics20 'Amount' address validation and tests #820

Closed M-Daeva closed 2 years ago

M-Daeva commented 2 years ago

cw20-ics20

  1. Added address verification for Amount::Cw20
  2. Added tests for Amount::from_parts
CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

uint commented 2 years ago

Hi! Thank you for the submission.

How is this LocalApi different from cosmwasm_std::testing::MockApi? At a glance it seems to do the exact same thing.

uint commented 2 years ago

I also don't think the logic we use in our mocks is supposed to be used in a production setting. I suspect this won't validate an address properly at all.

uint commented 2 years ago

Closing due to inactivity