CosmWasm / sylvia

CosmWasm smart contract framework
Apache License 2.0
96 stars 16 forks source link

chore: Remove version from workspace sylvia-derive dependency #198

Closed jawoznia closed 1 year ago

jawoznia commented 1 year ago

Motivation

Release-plz didn't update workspace-dependencies. Tried also to add workspace-dependency for cosmwasm-std but with no success.

Workaround

We can remove sylvia-derive version from deps and rely solely on path. In future we should come up with solution to automatize workspace dependencies update and migrate shared dependencies to workspace Cargo.toml

codecov[bot] commented 1 year ago

Codecov Report

Merging #198 (9303f53) into main (5b9f247) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   83.70%   83.70%           
=======================================
  Files          23       23           
  Lines        1172     1172           
=======================================
  Hits          981      981           
  Misses        191      191           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

hashedone commented 1 year ago

Why is that? DIdn't we want to move version entirely to per-project cargo?

jawoznia commented 1 year ago

Why is that? DIdn't we want to move version entirely to per-project cargo?

You mean workspace cargo? I made this change because version in workspace.dependency is not updated. For now it might be a WA.

jawoznia commented 1 year ago

After offline talk agree this would damage crates.io release