search

CosmWasm / sylvia

CosmWasm smart contract framework
Apache License 2.0
90 stars 14 forks source link

chore: Improve `no instantiation` error message #338

Closed jawoznia closed 4 months ago

jawoznia commented 4 months ago

98

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.17%. Comparing base (5888a88) to head (bc15684).

Files Patch % Lines
sylvia-derive/src/message.rs 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #338 +/- ## ========================================== - Coverage 85.23% 85.17% -0.07% ========================================== Files 37 37 Lines 2702 2704 +2 ========================================== Hits 2303 2303 - Misses 399 401 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kulikthebird commented 4 months ago

Only one thing bothers me - why the code coverage is not calculated properly here?

jawoznia commented 4 months ago

Only one thing bothers me - why the code coverage is not calculated properly here?

I think this is because trybuild invokes rustc on it's own per test file (otherwise tests would fail the original process run by us). Then it makes sense that tarpaulin doesn't incorporate those runs into it's report since those are separate processes.

It's sad as I thought we will be able to cover error cases using trybuild. Solution to this is not obvious to me at the moment so I will open a separate issue to track it.