search

CosmWasm / sylvia

CosmWasm smart contract framework
Apache License 2.0
93 stars 15 forks source link

feat: Executors #386

Closed kulikthebird closed 3 months ago

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 98.29545% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.15%. Comparing base (0e69cc8) to head (00cc2ad).

Files Patch % Lines
sylvia/tests/executor.rs 93.75% 2 Missing :warning:
sylvia/tests/remote.rs 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #386 +/- ## ========================================== + Coverage 85.48% 86.15% +0.67% ========================================== Files 37 39 +2 Lines 2639 2789 +150 ========================================== + Hits 2256 2403 +147 - Misses 383 386 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kulikthebird commented 3 months ago

According to #130 sylvia should provide reply_on method on the executor builder structure. From the sylvia point of view it's better not to duplicate the interface of SubMsg. Instead of adding reply_on() method on ExecutorBuilder, user should use build() method and then use on of the reply_* methods of SubMsg to create that strucutre.