search

CosmWasm / sylvia

CosmWasm smart contract framework
Apache License 2.0
93 stars 14 forks source link

Generic interfaces on examples #402

Closed abefernan closed 1 month ago

abefernan commented 1 month ago

Part of #399.

This PR deals with the "Interfaces" part of the issue above.

It also makes the affected contracts and tests use cosmwasm_std::Empty for their different implementations of the now generic interfaces.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.01%. Comparing base (df2fece) to head (4e0bafd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #402 +/- ## ======================================= Coverage 85.01% 85.01% ======================================= Files 42 42 Lines 2916 2916 ======================================= Hits 2479 2479 Misses 437 437 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

abefernan commented 1 month ago

In general looks ok, but I see couple CosmosCustomMsg and I don't know what are they about. Do we need those?

It seems like it's needed for now or else it won't compile. @jawoznia and @kulikthebird think it might be a bug in Sylvia