imp: allow cgo while disabling libwasmvm linking

CosmWasm / wasmvm

Go bindings to the running cosmwasm contracts with wasmer

Apache License 2.0

169 stars 100 forks source link

imp: allow cgo while disabling libwasmvm linking #527

Closed damiannolan closed 3 months ago

damiannolan commented 3 months ago

As discussed via comms channels.

Adds the ability to enable cgo but disable libwasmvm in binary compliation.

I will test this for the usecase mentioned with ibc 08-wasm before publishing the PR as ready for review. This is the associated PR on ibc-go: https://github.com/cosmos/ibc-go/pull/5923

And please let me know if I am missing something! 🖤

damiannolan commented 3 months ago

Marking as r4r. See https://github.com/cosmos/ibc-go/pull/5923#issuecomment-2009742393

Tested compiling with cgo enabled and using the custom build switch added here and had success!

webmaster128 commented 3 months ago

@mergify rebase release/2.0

mergify[bot] commented 3 months ago

rebase release/2.0

☑️ Nothing to do

- [ ] `-closed` [📌 rebase requirement] - [X] `-conflict` [📌 rebase requirement] - [X] `queue-position=-1` [📌 rebase requirement]

webmaster128 commented 3 months ago

@mergify backport release/2.0

mergify[bot] commented 3 months ago

backport release/2.0

✅ Backports have been created

* [#530 imp: allow cgo while disabling libwasmvm linking (backport #527)](https://github.com/CosmWasm/wasmvm/pull/530) has been created for branch `release/2.0` but encountered conflicts