Cosmetica-cc / Cosmetica

Custom public cosmetics, Free for everyone. Forever. Ongoing Development is happening at Cosmetica-2, still WIP
https://cosmetica.cc
Apache License 2.0
54 stars 11 forks source link

Cosmetics still rendering when the relevant model parts are hidden #72

Open craftish37 opened 1 year ago

craftish37 commented 1 year ago

https://github.com/tr7zw/FirstPersonModel/issues/301

Well well well

Might be quite easy to fix, I'll check if I can do it myslef in time, but I know some of you are just too fast for this world ._.

Every resource is available on the issue

Lumi1323 commented 1 year ago

It's buggy cause both separate mods would kill each other and it would break cosmetic rendering.

valoeghese commented 1 year ago

Regardless I'll use this to track the issue of cosmetics not hiding when the model part is not being rendered

craftish37 commented 1 year ago

huge_2023-06-20_15 22 33 Still happening in latest version (also applies to the nametag/lore)

valoeghese commented 10 months ago

isModelPartShown seems to only be for outer layers that are player-toggleable. I'll need to figure out if there's a way to check if one of the base parts is shown or not. Presumably not? The only time I can think parts aren't shown is first person, but they don't render any of the 3d model then anyway

craftish37 commented 8 months ago

Issue fixed with the latest build of First Person Model 😄 Might let it opened for future patches idk, how you want to do 🤷‍♂️