Cosmetica-cc / Cosmetica

Custom public cosmetics, Free for everyone. Forever. Ongoing Development is happening at Cosmetica-2, still WIP
https://cosmetica.cc
Apache License 2.0
54 stars 14 forks source link

Incorrect handling of Wynntils #73

Closed RuiNtD closed 1 year ago

RuiNtD commented 1 year ago

Describe the bug Wynntils' API isn't properly checked, resulting in problems when disabling cosmetics.

To Reproduce Steps to reproduce the behavior:

  1. Login to the Wynntils website
    • If you don't have an account, type /token from the Wynntils mod to create an account.
  2. Disable your cosmetics and save.
  3. Check your Wynntils cape from Cosmetica.

Expected behavior The Wynntils cape should be ignored and a different cape provider should be checked in its place.

Screenshots

Setup (please complete the following information):

Additional context The user's options are returned by: https://athena.wynntils.com/user/getInfo/(UUID with dashes) Example: https://athena.wynntils.com/user/getInfo/4a17f918-4870-4ca5-8106-05869bb7e6e9 Example with a non-Wynntils user (Notch): https://athena.wynntils.com/user/getInfo/069a79f4-44e9-4726-a5be-fca90e38aaf5

eyezahhhh commented 1 year ago

Cosmetica pulls from https://athena.wynntils.com/capes/user/4a17f918-4870-4ca5-8106-05869bb7e6e9 instead of https://athena.wynntils.com/user/getInfo/4a17f918-4870-4ca5-8106-05869bb7e6e9

Both endpoints seem to return the same cape, however /capes/user seems to be missing the context of whether the cape should be equipped or not (I assume that's how the Wynntils API works). So I'll work on getting that context working.

Just so you know, Cosmetica caches third party capes for 12 hours, so changes may not be instant.

eyezahhhh commented 1 year ago

This has been fixed on Wynntils end, so we don't have to do anything. Our API may take up to 24 hours to flush all outdated capes.