search

Cosmetica-cc / Cosmetica

Custom public cosmetics, Free for everyone. Forever. Ongoing Development is happening at Cosmetica-2, still WIP
https://cosmetica.cc
Apache License 2.0
54 stars 11 forks source link

Incompatibiity with Model Gap Fix #77

Closed valoeghese closed 1 year ago

valoeghese commented 1 year ago

Describe the bug ModelGapFix hooks in to one of the methods in TextureAtlasSprite to perform its function. It does a check for which texture atlas the sprite is using to know whether to apply its fixes, however we don't use a texture atlas on our ModelSprites, so it throws UnsupportedOperationException.

To Reproduce Steps to reproduce the behavior:

  1. Download Cosmetica 1.2.2 and Model Gap Fix
  2. Launch the game with both of them
  3. Get the game to render a cosmetica player (for example: by opening the cosmetica gui)
  4. Game crashes

Expected behavior A clear and concise description of what you expected to happen.

Dont crash

Screenshots (see crash log from RaptaG in the discord)

Setup (please complete the following information):

Additional context Fixed in development builds already by pretending to use the block atlas (will still crash when launched in a dev env as the original behaviour is useful for debug). This issue tracks it.

RaptaG commented 1 year ago

Please release the fix version

eyezahhhh commented 1 year ago

Fixed in 1.2.3.