Cosmetica-cc / Cosmetica

Custom public cosmetics, Free for everyone. Forever. Ongoing Development is happening at Cosmetica-2, still WIP
https://cosmetica.cc
Apache License 2.0
54 stars 11 forks source link

Not working as a beta-version? #91

Closed lunatic-gh closed 1 year ago

lunatic-gh commented 1 year ago

Describe the bug Mod not working in a beta-version. is this wanted behavior (for protecting the servers or similar) or a bug?

To Reproduce Steps to reproduce the behavior:

  1. Start the Game
  2. Console saying Cosmetica servers detected that you're rocking a beta version
  3. Error in console
  4. Cosmetica-Settings aren't working.

Expected behavior Welp... it's supposed to work i guess. lol.

Screenshots Cosmetics are working: image Can't open the Settings: image

Setup (please complete the following information):

Additional context It's failing to connect to the servers or something, i honestly have no idea. It spits out the following error on startup:

[20:41:09] [Cosmetica Authenticator #1/ERROR] (Cosmetica) Couldn't connect to cosmetica auth server
 java.lang.NullPointerException: Cannot invoke "cc.cosmetica.util.HostProvider.getSecureUrl()" because "this.apiHostProvider" is null
    at cc.cosmetica.impl.CosmeticaWebAPI.exchangeTokens(CosmeticaWebAPI.java:71) ~[CosmeticaDotJava-1.11.1.jar:?]
    at cc.cosmetica.impl.CosmeticaWebAPI.<init>(CosmeticaWebAPI.java:55) ~[CosmeticaDotJava-1.11.1.jar:?]
    at cc.cosmetica.impl.CosmeticaWebAPI.fromMinecraftToken(CosmeticaWebAPI.java:689) ~[CosmeticaDotJava-1.11.1.jar:?]
    at cc.cosmetica.api.CosmeticaAPI.fromMinecraftToken(CosmeticaAPI.java:481) ~[CosmeticaDotJava-1.11.1.jar:?]
    at cc.cosmetica.cosmetica.Authentication$1.run(Authentication.java:236) ~[main/:?]

The only thing that seems to be affected is the Settings-Screen, Cosmetics do work, and can be changed from the web-panel. still it's kinda off, as everything else is actually working, so i don't think it's supposed to do this.

eyezahhhh commented 1 year ago

Building the mod yourself from GitHub is use-at-your-own-risk as between releases the branches often contain unfinished or improperly tested code. Once we're happy with the stability of the branches, we release to CurseForge and Modrinth ourselves.

This bug you encountered has already been caught by our beta testers and fixed. If you want to get access to "semi-stable" betas, join our Discord server and request to be a beta tester.

valoeghese commented 1 year ago

Building from source has is and has always been build-at-your-own-risk. This is a pretty good example as to why.

I'm guessing you built it a few days ago? This bug was fixed in commit c8c55d34ab7440d4c467aa8352c05d7909fd96dc. If you build now it should be fixed.

As eyezah said, if you want semi-stable betas I recommend joining our beta testing team. We can always use another hand in helping us test and get a stable release quicker.

lunatic-gh commented 1 year ago

ive built it about 20 minutes before opening this issue. But yea, that was essentially the reason for opening this, so i can know if this is a bug, or not.

valoeghese commented 1 year ago

that's weird -- if you built it 20 minutes before opening the issue, you shouldn't be getting that issue (unless you cloned the repo before we pushed that commit). what version is your beta build?

lunatic-gh commented 1 year ago

sorry for the late answer.

i just used intellij's get from Version Control feature, and then checked out both the master and 1.19.4-branches present at that moment.

maybe intellij did some weird stuff, no idea, don't know the mod-version anymore either, but it's fixed now in the official build anyway, so i guess this is "fixed" lol