CosmiQ / CometTS

Comet Time Series Toolset for working with a time-series of remote sensing imagery and user defined polygons
Apache License 2.0
63 stars 16 forks source link

Remove or clarify commented-out code #7

Closed rmsare closed 5 years ago

rmsare commented 5 years ago

It's nice to see the tests pass, but there are a few instances of commented-out code in your tests and the example notebooks. You should remove these if they aren't necessary, or clarify if they can be run in certain cases (like you do in ARIMA.py and elsewhere).

This will make the examples more accessible and make it easier to extend or contribute to CometTS without wading through scratch code.

(You also might consider removing the statement "No plotting testing included, do your own damn plotting if you have a problem." I get that it's unrealistic to test all possible uses of bokeh and matplotlib in the CometTS workflow, but this could be a little off-putting to someone who might want to contribute.)

(JOSS review thread)

rmsare commented 5 years ago

Looks good - code has been cleaned up substantially