Closed nrweir closed 4 years ago
Merging #322 into dev will decrease coverage by
<.01%
. The diff coverage is66.66%
.
@@ Coverage Diff @@
## dev #322 +/- ##
==========================================
- Coverage 67.16% 67.15% -0.01%
==========================================
Files 72 72
Lines 5196 5204 +8
==========================================
+ Hits 3490 3495 +5
- Misses 1706 1709 +3
Impacted Files | Coverage Δ | |
---|---|---|
solaris/utils/core.py | 73.56% <66.66%> (-1.13%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 267d269...eca4c91. Read the comment docs.
Description
The initial PR for this subject (#319) didn't quite resolve all of the problems. This PR finishes it. Fixes #317
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe tests that you added to the pytest codebase (if applicable).
Checklist:
If your PR does not fulfill all of the requirements in the checklist above, that's OK! Just prepend [WIP] to the PR title until they are all satisfied. If you need help, @-mention a maintainer and/or add the Status: Help Needed label.