CosmiQ / solaris

CosmiQ Works Geospatial Machine Learning Analysis Toolkit
https://solaris.readthedocs.io
Apache License 2.0
413 stars 112 forks source link

Expanded metrics v3 #381

Closed jshermeyer closed 4 years ago

jshermeyer commented 4 years ago

Thank you for submitting your PR. Please read the template below, fill it out as appropriate, and make additional changes to your code as needed. Please feel free to submit your PR even if it doesn't satisfy all of the requirements below - simply prepend [WIP] to the PR title until it is ready for review by a maintainer. If you need assistance or review from a maintainer, add the label Status: Help Needed or Status: Review Needed respectively. After review, a maintainer will add the label Status: Revision Needed if further work is required for the PR to be merged.

Description

Bug fix for when a proposal class doesn't overlap with the ground truth and speed improvements

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe tests that you added to the pytest codebase (if applicable).

Checklist:

If your PR does not fulfill all of the requirements in the checklist above, that's OK! Just prepend [WIP] to the PR title until they are all satisfied. If you need help, @-mention a maintainer and/or add the Status: Help Needed label.

codecov[bot] commented 4 years ago

Codecov Report

Merging #381 into dev will decrease coverage by 0.03%. The diff coverage is 62.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #381      +/-   ##
==========================================
- Coverage   56.75%   56.72%   -0.04%     
==========================================
  Files          80       80              
  Lines        6806     6835      +29     
==========================================
+ Hits         3863     3877      +14     
- Misses       2943     2958      +15     
Impacted Files Coverage Δ
solaris/eval/vector.py 85.88% <61.66%> (-7.74%) :arrow_down:
tests/test_eval/vector_test.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5bf48f5...d0cbdb5. Read the comment docs.