CosmiQ / solaris

CosmiQ Works Geospatial Machine Learning Analysis Toolkit
https://solaris.readthedocs.io
Apache License 2.0
413 stars 112 forks source link

[WIP] SpaceNet6 Competitor #1 - Zbigniewwojna Model Incorporation & Model Loading Bug Fix #389

Closed roshanr11 closed 2 years ago

roshanr11 commented 4 years ago

Thank you for submitting your PR. Please read the template below, fill it out as appropriate, and make additional changes to your code as needed. Please feel free to submit your PR even if it doesn't satisfy all of the requirements below - simply prepend [WIP] to the PR title until it is ready for review by a maintainer. If you need assistance or review from a maintainer, add the label Status: Help Needed or Status: Review Needed respectively. After review, a maintainer will add the label Status: Revision Needed if further work is required for the PR to be merged.

Description

Please include a summary of the change and which issue is resolved. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe tests that you added to the pytest codebase (if applicable).

Checklist:

If your PR does not fulfill all of the requirements in the checklist above, that's OK! Just prepend [WIP] to the PR title until they are all satisfied. If you need help, @-mention a maintainer and/or add the Status: Help Needed label.

codecov[bot] commented 4 years ago

Codecov Report

Merging #389 into dev will decrease coverage by 7.65%. The diff coverage is 21.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #389      +/-   ##
==========================================
- Coverage   56.34%   48.69%   -7.66%     
==========================================
  Files          81       96      +15     
  Lines        6907     8853    +1946     
==========================================
+ Hits         3892     4311     +419     
- Misses       3015     4542    +1527     
Impacted Files Coverage Δ
solaris/nets/model_io.py 17.72% <0.00%> (ø)
solaris/nets/zoo/geffnet/version.py 0.00% <0.00%> (ø)
solaris/nets/zoo/base.py 7.60% <7.60%> (ø)
solaris/nets/zoo/geffnet/efficientnet_builder.py 11.93% <11.93%> (ø)
solaris/nets/zoo/geffnet/helpers.py 13.46% <13.46%> (ø)
solaris/nets/zoo/geffnet/mobilenetv3.py 20.93% <20.93%> (ø)
solaris/nets/zoo/woj_sn6.py 23.66% <23.66%> (ø)
solaris/nets/zoo/geffnet/gen_efficientnet.py 23.90% <23.90%> (ø)
solaris/nets/zoo/geffnet/conv2d_layers.py 23.97% <23.97%> (ø)
solaris/nets/zoo/geffnet/model_factory.py 33.33% <33.33%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe7cc53...e35929e. Read the comment docs.

rbavery commented 2 years ago

Closing as this PR includes spacenet related functionality, which no longer aligns with the solaris roadmap https://github.com/CosmiQ/solaris/blob/32236217bd913fbb238e19f2f8420e5794fd8136/ROADMAP.md