CosmiQ / solaris

CosmiQ Works Geospatial Machine Learning Analysis Toolkit
https://solaris.readthedocs.io
Apache License 2.0
413 stars 112 forks source link

Updated Dockerfile to include /tcp Status: Review Needed #412

Closed AH-Merii closed 3 years ago

AH-Merii commented 3 years ago

Build was failing without inclusion of /tcp when exposing the ports.

Thank you for submitting your PR. Please read the template below, fill it out as appropriate, and make additional changes to your code as needed. Please feel free to submit your PR even if it doesn't satisfy all of the requirements below - simply prepend [WIP] to the PR title until it is ready for review by a maintainer. If you need assistance or review from a maintainer, add the label Status: Help Needed or Status: Review Needed respectively. After review, a maintainer will add the label Status: Revision Needed if further work is required for the PR to be merged.

Description

When building the dockerfile, the build fails during the last EXPOSE stage. The following error is printed out:

docker: Error response from daemon: OCI runtime create failed: container_linux.go:349: starting container process caused "exec: \"-p\": executable file not found in $PATH": unknown.
ERRO[0000] error waiting for container: context canceled

In order to fix this issue I specified the /tcp standard during the expose.

Fixes # (issue) Fixes Docker build failing.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Tested by simply building the dockerfile. Currently there are no tests to verify that the dockerfile is being built with no errors.

Checklist:

If your PR does not fulfill all of the requirements in the checklist above, that's OK! Just prepend [WIP] to the PR title until they are all satisfied. If you need help, @-mention a maintainer and/or add the Status: Help Needed label.

codecov[bot] commented 3 years ago

Codecov Report

Merging #412 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #412   +/-   ##
=======================================
  Coverage   55.36%   55.36%           
=======================================
  Files          82       82           
  Lines        7135     7135           
=======================================
  Hits         3950     3950           
  Misses       3185     3185           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e596041...0d8a871. Read the comment docs.

AH-Merii commented 3 years ago

Hey @nrweir , I am trying to figure out how to add the review needed label to get this reviewed. I can't seem to figure out how to update the label so that I can get this reviewed.