CosmiQ / solaris

CosmiQ Works Geospatial Machine Learning Analysis Toolkit

https://solaris.readthedocs.io

Apache License 2.0

413 stars 112 forks source link

Fix missing comma in setup.py that breaks conda environment export Status: Review Needed #420

Closed rbavery closed 2 years ago

rbavery commented 3 years ago

Description

I was getting a conda env export error when exporting a complex but correctly built environment:

# rave at rave-desktop in ~/CropMask_RCNN/app on git:pytorchapi ✖︎ [0:18:31]
→ conda env export > app-environment-exp.yml                                                        

InvalidVersionSpec: Invalid version '3.0.2geopandas>=0.7.0': invalid character(s)

This comment showed me that the issue could be in the setup.py of a dependency and it turned out to be right.

I found the issue was in solaris by searching for the string 3.0.2geopandas>=0.7.0

grep -r "3.0.2geopandas>=0.7.0" ~/miniconda3/envs/cropmask/lib/python3.7/site-packages/

Fixes # (issue)

Add a comma in setup.py

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

I'm not sure who is the current maintainer so I'll at @dphogan, but a review and merge from anyone will do! Thanks in advance for reviewing.

rbavery commented 2 years ago

will be superseded by https://github.com/CosmiQ/solaris/pull/436