CosmiQ / solaris

CosmiQ Works Geospatial Machine Learning Analysis Toolkit
https://solaris.readthedocs.io
Apache License 2.0
412 stars 112 forks source link

Add partial support for pathlib.Path objects in raster and vector modules __Status: Review Needed__ #430

Closed remtav closed 2 years ago

remtav commented 3 years ago

Thank you for submitting your PR. Please read the template below, fill it out as appropriate, and make additional changes to your code as needed. Please feel free to submit your PR even if it doesn't satisfy all of the requirements below - simply prepend [WIP] to the PR title until it is ready for review by a maintainer. If you need assistance or review from a maintainer, add the label Status: Help Needed or Status: Review Needed respectively. After review, a maintainer will add the label Status: Revision Needed if further work is required for the PR to be merged.

Description

Add partial support for pathlib.Path objects in raster and vector modules

Fixes # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe tests that you added to the pytest codebase (if applicable).

Checklist:

If your PR does not fulfill all of the requirements in the checklist above, that's OK! Just prepend [WIP] to the PR title until they are all satisfied. If you need help, @-mention a maintainer and/or add the Status: Help Needed label.

rbavery commented 2 years ago

@remtav thanks for your contribution! I and my colleagues at Development Seed are taking on maintainership of this library. Work is ongoing in https://github.com/CosmiQ/solaris/pull/436 to focus this library's scope, see https://github.com/CosmiQ/solaris/blob/32236217bd913fbb238e19f2f8420e5794fd8136/ROADMAP.md for details. This sounds like a valuable PR that would make sense to be introduced after a .5 release, feel free to resubmit this PR or request this PR be re-opened after .5 is released.