Cosmic-Chatter / Exhibitera

Free and open-source software for building and controlling museum exhibits.
MIT License
1 stars 1 forks source link

Adding in initial support for a Keyboard to Word Cloud #7

Closed alexaverill closed 2 weeks ago

alexaverill commented 3 weeks ago

Adding in the ability of a keyboard to be used for entering text into the Word Cloud. This includes a toggle-able setting during setup, and defaults to off. If this setting is enabled it will hide the on screen keyboard at the moment.

Additionally I thought there would be value in also being able to control the max character length of an entered word if desired. I added in that setting as well, with its default state to not do anything. It also will display a character count to the user if there is one enabled. (Color can be controlled through settings)

This addresses issue #6

Samples:

Screenshot 2024-04-28 at 5 54 35 PM Screenshot 2024-04-28 at 5 54 12 PM Screenshot 2024-04-28 at 5 53 58 PM Screenshot 2024-04-28 at 5 53 43 PM Screenshot 2024-04-28 at 5 53 26 PM Screenshot 2024-04-28 at 6 19 17 PM Screenshot 2024-04-28 at 6 26 44 PM
forceflow1049 commented 2 weeks ago

Hi @alexaverill this is a really nice addition. I love the character count. I committed some tweaks to the label and hint text to bring them in line with the style elsewhere.

Two requests:

By the way, I changed your PR to point to the Dev_5.1 branch rather than main.

alexaverill commented 2 weeks ago

@forceflow1049 good call outs, I cleaned those up. The first one was just bad initial placement of the defaults. I'll point future PRs towards the latest dev branches!