search

CosmicDan-Minecraft / SleepingOverhaul

Replaces the vanilla "skip-to-day" function of sleep with an immersive time-lapse sleep (speeds up time), among other configurable sleep enhancements.
Other
3 stars 0 forks source link

[Request] increase randomtickrate to match tickrate during sleep to simulate crops etc. as well #4

Closed xkforce closed 6 years ago

xkforce commented 6 years ago

Currently sleepingoverhaul uses the tickratechanger mod to increase the tickrate during sleep to simulate the passage of time. But the problem is that since crops and other blocks that use randomtickrate instead, these crops grow normally instead of growing at the rate they would be expected to during the amount of time the player is sleeping.

cosmicdan commented 6 years ago

Are you absolutely sure about that? I'm almost certain I remember testing Tickrate Changer with trees, and it did indeed seem to increase the rate at which they grow.

On 26 Nov 2018, xkforce notifications@github.com wrote:

Currently sleepingoverhaul uses the tickratechanger mod to increase the tickrate during sleep to simulate the passage of time. But the problem is that since crops and other blocks that use randomtickrate instead, these crops grow normally instead of growing at the rate they would be expected to during the amount of time the player is sleeping.

-- Sent with K-@ Mail - the evolution of emailing.

xkforce commented 6 years ago

https://www.twitch.tv/videos/340885745

There's a test I ran a few minutes ago.

I also tried this with cacti both with the bed and with the randomTickSpeed gamerule. The difference in growth rate between the tick rate set in the config and the equivalent randomtickspeed gamerule setting (3 is the default for randomtickspeed and 20 for the tickrate so the equivalent for 1000 tickrate is 150 randomtickspeed since 1000 * 3/20 = 150) is noticeable.

https://github.com/Guichaguri/TickrateChanger/issues/6

There's the issue report I made about it on tickratechanger to make sure it wasn't something on their end.

cosmicdan commented 6 years ago

Dont crops need a light source to grow? I didn't see you put a torch down.

Sent from Mailspring (https://link.getmailspring.com/link/1543214333.local-17aff94c-f650-v1.5.2-31660462@getmailspring.com/0?redirect=https%3A%2F%2Fgetmailspring.com%2F&recipient=cmVwbHkrMDAxZmVlODRlYmY1NTJhODM4ZmYzOTNhNmMwMjVhNDczM2ViMjUzYmM3MmE4ODdjOTJjZjAwMDAwMDAxMTgxMzUxM2M5MmExNjljZTE2ZTVmYjk5QHJlcGx5LmdpdGh1Yi5jb20%3D), the best free email app for work On Nov 26 2018, at 5:14 pm, xkforce notifications@github.com wrote:

https://www.twitch.tv/videos/340885745 (https://link.getmailspring.com/link/1543214333.local-17aff94c-f650-v1.5.2-31660462@getmailspring.com/1?redirect=https%3A%2F%2Fwww.twitch.tv%2Fvideos%2F340885745&recipient=cmVwbHkrMDAxZmVlODRlYmY1NTJhODM4ZmYzOTNhNmMwMjVhNDczM2ViMjUzYmM3MmE4ODdjOTJjZjAwMDAwMDAxMTgxMzUxM2M5MmExNjljZTE2ZTVmYjk5QHJlcGx5LmdpdGh1Yi5jb20%3D) There's a test I ran a few minutes ago. I also tried this with cacti both with the bed and with the randomTickSpeed gamerule. The difference in growth rate between the tick rate set in the config and the equivalent randomtickspeed gamerule setting (3 is the default for randomtickspeed and 20 for the tickrate so the equivalent for 1000 tickrate is 150 randomtickspeed since 1000 * 3/20 = 150) is noticeable. Guichaguri/TickrateChanger#6 (https://link.getmailspring.com/link/1543214333.local-17aff94c-f650-v1.5.2-31660462@getmailspring.com/2?redirect=https%3A%2F%2Fgithub.com%2FGuichaguri%2FTickrateChanger%2Fissues%2F6&recipient=cmVwbHkrMDAxZmVlODRlYmY1NTJhODM4ZmYzOTNhNmMwMjVhNDczM2ViMjUzYmM3MmE4ODdjOTJjZjAwMDAwMDAxMTgxMzUxM2M5MmExNjljZTE2ZTVmYjk5QHJlcGx5LmdpdGh1Yi5jb20%3D) There's the issue report I made about it on tickratechanger to make sure it wasn't something on their end. — You are receiving this because you commented. Reply to this email directly, view it on GitHub (https://link.getmailspring.com/link/1543214333.local-17aff94c-f650-v1.5.2-31660462@getmailspring.com/3?redirect=https%3A%2F%2Fgithub.com%2FCosmicDan-Minecraft%2FSleepingOverhaul%2Fissues%2F4%23issuecomment-441529860&recipient=cmVwbHkrMDAxZmVlODRlYmY1NTJhODM4ZmYzOTNhNmMwMjVhNDczM2ViMjUzYmM3MmE4ODdjOTJjZjAwMDAwMDAxMTgxMzUxM2M5MmExNjljZTE2ZTVmYjk5QHJlcGx5LmdpdGh1Yi5jb20%3D), or mute the thread (https://link.getmailspring.com/link/1543214333.local-17aff94c-f650-v1.5.2-31660462@getmailspring.com/4?redirect=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB_uhFcOMruDvYZj4qKh8-9Ou3CbgIuiks5uy4a8gaJpZM4YyTxA&recipient=cmVwbHkrMDAxZmVlODRlYmY1NTJhODM4ZmYzOTNhNmMwMjVhNDczM2ViMjUzYmM3MmE4ODdjOTJjZjAwMDAwMDAxMTgxMzUxM2M5MmExNjljZTE2ZTVmYjk5QHJlcGx5LmdpdGh1Yi5jb20%3D).

xkforce commented 6 years ago

Yes crops need light and these crops are out in the open sun. I've done many other tests, this was just a very short example. The growth rate of crops with tickratechanger are about 5x faster than they normally are but that is about 10x slower than they should be. About 90% of plant growth appears to be the result of randomtickrate rather than scheduled ticks.

cosmicdan commented 6 years ago

Well I'm afraid this is outside the scope of Sleeping Overhaul. It's something that should be done on Tickrate Changer's end, if he has the time or interest to do so.