search

CosmicHorrorDev / vdf-rs

VDF parsing and (de)serialization for Rust
Apache License 2.0
31 stars 3 forks source link

Get rid of regex dependency in `keyvalues-serde` #22

Closed CosmicHorrorDev closed 2 years ago

CosmicHorrorDev commented 3 years ago

Regex is only used to try and determine the type from the contents for Any. I don't think this is great though since the types aren't very robust in VDF, so instead I think it would be better to error when trying to use Any and have ignored values just emit None instead

CosmicHorrorDev commented 2 years ago

I've decided to not try to infer types since I see no obvious way to handle promoting types (a bool can become an int for example) so it's only likely to cause more problems than it solves