search

CosmicMind / Material

A UI/UX framework for creating beautiful applications.
http://cosmicmind.com
MIT License
11.99k stars 1.26k forks source link

Title label appearing on top of Navigation bar buttons #112

Closed sohayb closed 8 years ago

sohayb commented 8 years ago

When the title is big enough, the title labels appears on top of the top buttons, I think that the title label width in the NavigationBarView should be calculated based on the buttons width.

screen shot 2016-01-02 at 6 12 58 pm
sohayb commented 8 years ago

Well I solved it like this:

navigationBarView.titleLabelInsetsRef.right = 192

But that brings me to another issue I wanted to discuss since forever, I think the NavigationBarView takes so much code to get initialised. I guess having @IBDesignable can solve part of the issue, what do you guys think?

daniel-jonathan commented 8 years ago

Agreed, I will make that adjustment today with the SearchBarView I am working on :)

sohayb commented 8 years ago

That's some great news!!! :+1:

daniel-jonathan commented 8 years ago

I thought you would like that :)

Daniel Dahan

M: +1 647.627.0770 Skype: djondahan

On Jan 2, 2016, at 12:23 PM, Sohayb Hassoun notifications@github.com wrote:

That's some great news!!!

— Reply to this email directly or view it on GitHub https://github.com/CosmicMind/MaterialKit/issues/112#issuecomment-168409226.

daniel-jonathan commented 8 years ago

@sohayb So this isn't actually a bug, it was part of the design. It was left to the developer to manage this. In the next release, the SearchBarView and NavigationBarView will handle the sizing as suggested.

Thank you!