search

CosmicMind / Material

A UI/UX framework for creating beautiful applications.
http://cosmicmind.com
MIT License
11.99k stars 1.26k forks source link

Pulse animation stuck #1181

Open gedzionsas opened 6 years ago

gedzionsas commented 6 years ago

Hi, I got problem with pulse animation, when I press on button and swipe to next controller with UIViewControllerAnimatedTransitioning, after that I get back to controller with button and pulse animation is stucked because touchesCancelled not called, could you help me with that?

OrkhanAlikhanov commented 6 years ago

Hey! To be honest, I did experience that somehow, but was never able to find steps to reproduce it, can you share a sample project replicating the issue?

daniel-jonathan commented 6 years ago

Hey! I think this is because of the touch event to shrink the pulse is not fired when there is a swipe. @OrkhanAlikhanov I think we can set a timer on the pulse if the user hasn't released it, or we can look for when the button is offscreen, no longer being rendered, and update the animation lifecycle. These are some quick ideas as I think about this issue.

gedzionsas commented 6 years ago

Yes, it's completed because touchesCancelled not fired, I believe that detecting when button offscreen would help.

daniel-jonathan commented 6 years ago

@OrkhanAlikhanov let's discuss this in Slack, @gedzionsas if you would like to join our #opensource slack channel, please send us your email at support@cosmicmind.com. I will leave this issue up until we resolve it. Thank you!